FIX-#7272: Remove HDK engine #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
YarShev
requested review from
aregm,
gshimansky,
ienkovich,
Garra1980,
vnlitvinov,
anmyachev,
dchigarev,
AndreyPavlenko,
a team,
devin-petersohn,
mvashishtha and
RehanSD
as code owners
anmyachev
reviewed
May 16, 2024
Comment on lines
-184
to
-186
| With ``conda`` it is also possible to install `Intel Distribution of Modin`_, a special version of Modin | ||
| that is part of Intel\ |reg| oneAPI AI Analytics Toolkit. This version of Modin is powered by :doc:`HDK</development/using_hdk>` | ||
| engine that contains a bunch of optimizations for Intel hardware. More details to get started can be found in the `Intel Distribution of Modin Getting Started`_ guide. |
There was a problem hiding this comment.
Are you planning to remove mention of Intel Distribution of Modin completely?
There was a problem hiding this comment.
I don't see a need to mention it as Intel Distribution of Modin mostly relied on HDK engine, as well as we were supporting modin package on conda intel channel. Since HDK is no longer supported and we are stopping support for modin package on conda intel channel, there is no need to refer to Intel Distribution of Modin as some special/different package. Instead, we will refer from Intel Distribution of Modin docs to the official Modin documentation, which is public.
anmyachev
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date