REFACTOR-#7294: Reduce access of methods _modin_frame methods from query compiler objects #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjose696
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
arunjose696
force-pushed
the
refactorQC
branch
3 times, most recently
from
4ba54e8
to
b8d07a7
Compare
7 tasks
anmyachev
requested changes
Jun 3, 2024
| Returns | ||
| ------- | ||
| bool | ||
| True if if the undelying dataframe and False otherwise. |
There was a problem hiding this comment.
Suggested change
| True if if the undelying dataframe and False otherwise. |
| @@ -4521,6 +4521,60 @@ def has_multiindex(self, axis=0): | |||
| assert axis == 1 | |||
| return isinstance(self.columns, pandas.MultiIndex) | |||
|
|
|||
| @property | |||
| def has_materialized_dtypes(self) -> bool: | |||
There was a problem hiding this comment.
By analogy
Suggested change
| def has_materialized_dtypes(self) -> bool: | |
| def frame_has_materialized_dtypes(self) -> bool: |
…thods from _query_compiler
YarShev
reviewed
Jun 10, 2024
| @@ -4521,6 +4521,59 @@ def has_multiindex(self, axis=0): | |||
| assert axis == 1 | |||
| return isinstance(self.columns, pandas.MultiIndex) | |||
|
|
|||
| @property | |||
| def frame_has_materialized_dtypes(self) -> bool: | |||
There was a problem hiding this comment.
@anmyachev, @arunjose696, why didn't we add similar methods for operating on columns?
There was a problem hiding this comment.
Apparently the relevant code was simply not touched when working on the small query compiler. There is no reason not to do this for columns.
There was a problem hiding this comment.
I would propose to do this for consistency. @arunjose696, would you take on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date