Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#0000: Update RunLLM Ask AI widget path #7345

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Jul 16, 2024

What do these changes do?

This PR to updates the widget's script path. RunLLM has switched to a new deployment framework which resolved multiple package delivery issues caused by jscdn caching. This improvement ensures RunLLM's askAI widget is more consistently up-to-date.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@likawind likawind changed the title Update RunLLM widget path DOCS - Update RunLLM Ask AI widget path Jul 16, 2024
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likawind, thanks!

@YarShev YarShev changed the title DOCS - Update RunLLM Ask AI widget path DOCS-#0000: Update RunLLM Ask AI widget path Jul 16, 2024
@YarShev
Copy link
Collaborator

YarShev commented Jul 16, 2024

@likawind, could you correct the commit message to be in line with our rules for commits?

@likawind
Copy link
Contributor Author

@YarShev thanks for updating the PR title. I also redo the commit and corrected the message

@YarShev
Copy link
Collaborator

YarShev commented Jul 18, 2024

@likawind, you should also sign off your commit message. Could you ping us when you do this?

Signed-off-by: Wei Chen <wei@runllm.com>
@likawind
Copy link
Contributor Author

@YarShev thank you! Updated the commit message, lmk if you have any other suggestions

Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likawind, LGTM, thanks!

@YarShev YarShev merged commit f5f9ae9 into modin-project:main Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants