Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Django 3.0.2: django.utils.six problem #110

Closed
MHM5000 opened this issue Jan 11, 2020 · 4 comments
Closed

Upgrade to Django 3.0.2: django.utils.six problem #110

MHM5000 opened this issue Jan 11, 2020 · 4 comments

Comments

@MHM5000
Copy link

MHM5000 commented Jan 11, 2020

Describe the bug
Since Django removed django.utils.six from its core, we should be using the six package.

To Reproduce
Install django-advanced-filters in a django>=3.0.0 environment.

Expected behavior
Work without any problem!

Details (please complete the following information):

  • OS: Ubuntu 16.04
  • Python version 3.6.8
  • Django version 3.0.2
  • django-advanced-filters version 1.1.1
  • Browser -
  • Version -

Additional context

  File "/some/sub/folder/proj/proj/urls.py", line 40, in <module>
    path('advanced_filters/', include('advanced_filters.urls')),

or

  File "/some/sub/folder/proj/app/admin.py", line 9, in <module>
    from advanced_filters.admin import AdminAdvancedFiltersMixin
@MHM5000 MHM5000 changed the title Upgrade toDjango 3.0.2 django.utils.six problem Upgrade to Django 3.0.2: django.utils.six problem Jan 11, 2020
@serjant
Copy link

serjant commented Jan 29, 2020

I am having the same issue

@asfaltboy
Copy link
Member

Thanks guys, would either of you consider submitting a pull-request to fix this?
Also, adding Django 3.0 to the test matrix would make this support "official"

PetrDlouhy added a commit to PetrDlouhy/django-advanced-filters that referenced this issue Feb 4, 2020
@PetrDlouhy
Django 3.0
395894a 
fix modlinltd#110
@PetrDlouhy PetrDlouhy mentioned this issue Feb 4, 2020
Closed
PetrDlouhy added a commit to PetrDlouhy/django-advanced-filters that referenced this issue Feb 4, 2020
@PetrDlouhy
Django 3.0
af33f88 
fix modlinltd#110
@zbynekdrlik
Copy link

+1

@zbynekdrlik
Copy link

When the new version will be out?

alonraiz added a commit to alonraiz/django-advanced-filters that referenced this issue May 16, 2021
@alonraiz @asfaltboy
@ravaan @PetrDlouhy @maingoh @jbsanf @TrangPham
Modlinltd master (#8)
fb38ffc 
* update README

remove confusion from the installation instruction

* test: refactor unittest test cases to pytest

* chore: replace deprecated assertEquals

* chore: replace deprecated logger.warn with warning

* style: correct small code style bugs

* chore: bump test dependencies

* use soft version for coveralls to support python 2.7
* use pycodestyle instead of older pep8
* bump to latest versions of factory-boy and pytest-django

* Update CI (#1)

* fixup! test: refactor unittest test cases to pytest

* fix: update requirements for new test deps matrix

* use tox-travis to keep the travis and tox requirements fairly clean
* drop versions <3.5 and add released 3.8
* use travis python config and specify pypy3.6
* allow any version of coveralls (easier support for python 2.7)
* add up to django 3.0 version according to official dep matrix:

Refs:
- https://www.djangoproject.com/download/#supported-versions
- https://docs.djangoproject.com/en/dev/faq/install/

* Django 3.0

fix modlinltd#110

* fix: switch deprecated force_text to force_str

* fix: avoid installing newer braces

due to hard requirement of Django 1.11, it's incompatible with our
wish to still support django versions 1.9 and 1.10

* fixup! test: refactor unittest test cases to pytest

* chore: update python and add Django classifiers

* docs: update dependencies stated in the README

+ update link to vtiger ref

* test: add a failing test_choices_has_null

required setting a string field to nullable in the Client test model

+ test that datetime field choices are being excluded

* fix: allow choices sort on None fields

; Conflicts:
;	advanced_filters/views.py

* add release workflow

* test: test the CleanWhiteSpacesMixin helper

* chore: update changelog and bump version to 1.2.0

* docs: fix typo and clarify title

Switching to using the python publish github action which uses
twine to push source and wheel to pypi whenever a release is created
in GitHub

* fix: correct travis.yml deprecated/dupe keywords

* Update django-braces

* import FieldDoesNotExist from django.core.exceptions

* fix: update test matrix to include Django 3.1

Ref: https://docs.djangoproject.com/en/3.1/faq/install/

* chore(setup.py): add Django 3.1 to classifiers

+ sort imports

* Add Turkish translation

* Update Admin to show model

* Add support for python 3.9 and django 3.1

* chore: update changelog and bump version to 1.3.0

Co-authored-by: Pavel Savchenko <asfaltboy@gmail.com>
Co-authored-by: Arpit <ravaan@users.noreply.github.com>
Co-authored-by: Petr Dlouhý <petr.dlouhy@email.cz>
Co-authored-by: Hugo Maingonnat <hugo@deepomatic.com>
Co-authored-by: João Batista <joaobatista.sf@hotmail.com>
Co-authored-by: predatell <predatell@bitmessage.ch>
Co-authored-by: Özcan YARIMDÜNYA <ozcan.yarimdunya@gtech.com.tr>
Co-authored-by: Thu Trang Pham <thuutrangpham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Django 3.0 PetrDlouhy/django-advanced-filters
4 participants
@asfaltboy @serjant @MHM5000 @zbynekdrlik