static_assert 2check if DIVISION fits UnderlyingType

src/modm/driver/encoder/encoder_input.hpp

@@ -9,11 +9,11 @@
  */
 // ----------------------------------------------------------------------------
 
-#ifndef MODM_ENCODER_HPP
-#define MODM_ENCODER_HPP
+#ifndef MODM_ENCODER_INPUT_HPP
+#define MODM_ENCODER_INPUT_HPP
 
-#include <modm/platform.hpp>
 #include <bit>
+#include <modm/platform.hpp>
 #include <type_traits>
 
 namespace modm
@@ -36,16 +36,15 @@ namespace modm
  * @tparam DIVISION		 	Resolution: How many Singal toggles to count one increment.
  * @tparam UnderlyingType	Must be signed integer
  */
-template<
-	typename SignalA,
-	typename SignalB,
-	uint8_t DIVISION = 4,
-	std::signed_integral UnderlyingType = int8_t
-	>
+template<typename SignalA, typename SignalB, uint8_t DIVISION = 4,
+		 std::signed_integral UnderlyingType = int8_t>
 class BitBangEncoderInput
 {
-	static_assert(std::popcount(DIVISION) == 1, "DIVISION must be an integer to basis 2 and not 0.");
-
+	static_assert(std::popcount(DIVISION) == 1,
+				  "DIVISION must be an integer to basis 2 and not 0. F.e. 1, 2, 4, 8, ...");
+	static_assert(DIVISION <= std::numeric_limits<UnderlyingType>::max(),
+				  "UnderlyingType is to small for DIVISION.");
+
 	using Phases = modm::platform::SoftwareGpioPort<SignalA, SignalB>;
 
 public:
@@ -58,8 +57,8 @@ class BitBangEncoderInput
 		Phases::setInput(::Gpio::InputType::PullUp);
 
 		// Tare power-on state
-		modm::delay(10us);
 		UnderlyingType raw = 0;
+		modm::delay(10us);
 		auto read = Phases::read();
 		if (read & 0b10) raw = 3;
 		if (read & 0b01) raw ^= 1;
@@ -81,4 +80,4 @@ class BitBangEncoderInput
 
 #include "encoder_input_impl.hpp"
 
-#endif  // MODM_ENCODER_HPP
+#endif  // MODM_ENCODER_INPUT_HPP

src/modm/driver/encoder/encoder_input_impl.hpp

@@ -1,4 +1,4 @@
-#ifndef MODM_ENCODER_HPP
+#ifndef MODM_ENCODER_INPUT_IMPL_HPP
 #error "Don't include this file directly, use 'encoder_input.hpp' instead!"
 #endif