Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[driver] Add AS5600 driver + generalize data-type for external encoders #1166

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

TomSaw
Copy link
Contributor

@TomSaw TomSaw commented Jun 10, 2024

Driver for a small and cheap magnetic encoder.

First, i've generalized the angle data type of existing magnetic encoder driver as5047.
👉 A consequent follow up would be to integrate driver/encoder/angle.hpp with math/geometry/angle.hpp. F.e. by adding conversion constructors to math/geometry/angle.hpp and drop the redundant methods ::toRadian() and ::toDegree() in driver/encoder/angle.hpp. But we might also just keep it as it is.

What do you think?

@TomSaw TomSaw force-pushed the driver/as5600 branch 4 times, most recently from 56b690d to 07b44f8 Compare June 10, 2024 12:55
@TomSaw TomSaw changed the title [driver] add driver/encoder/as5600 [driver] Add AS5600 driver and generalize data-type for encoders Jun 10, 2024
@TomSaw TomSaw changed the title [driver] Add AS5600 driver and generalize data-type for encoders [driver] Add AS5600 driver and generalize data-type for external encoders Jun 10, 2024
@TomSaw TomSaw changed the title [driver] Add AS5600 driver and generalize data-type for external encoders [driver] Add AS5600 driver + generalize data-type for external encoders Jun 10, 2024
src/modm/driver/encoder/angle.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
@salkinium salkinium added this to the 2024q2 milestone Jun 15, 2024
@TomSaw
Copy link
Contributor Author

TomSaw commented Jun 15, 2024

Done @salkinium

  • rebase required

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs

src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/math/geometry/angle_int.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Show resolved Hide resolved
src/modm/driver/encoder/as5600.hpp Show resolved Hide resolved
src/modm/math/geometry/angle_int.hpp Show resolved Hide resolved
@TomSaw TomSaw force-pushed the driver/as5600 branch 2 times, most recently from 984dc8f to e049ce7 Compare June 16, 2024 06:59
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more thing

src/modm/driver/encoder/as5600.hpp Outdated Show resolved Hide resolved
src/modm/math/geometry/angle_int.hpp Outdated Show resolved Hide resolved
src/modm/math/geometry/angle_int.hpp Outdated Show resolved Hide resolved
@TomSaw
Copy link
Contributor Author

TomSaw commented Jun 17, 2024

Ready to merge I'd say...

@TomSaw TomSaw requested a review from salkinium June 17, 2024 20:20
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

@salkinium salkinium merged commit 55c88ba into modm-io:develop Jun 17, 2024
12 checks passed
@TomSaw TomSaw deleted the driver/as5600 branch June 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants