-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCC 13 __FPU_PRESENT redefinition warning #1191
Fix GCC 13 __FPU_PRESENT redefinition warning #1191
Conversation
Looks like one of the tests failed due to running out of space?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think you're and this is the correct way to define the required macros.
90e417f
to
bfcd7ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bfcd7ed
to
d8e46d6
Compare
Something in this PR breaks the CMSIS DSP examples on Nucleo-F429. I've split the F4 examples into three jobs now and it still overflows disk space… |
Super weird. Seems like there's also an issue with |
Ok, I've been digging into the Nucleo-F429 issue. The cause of all the disk usage is two-fold:
We could fix the issue by moving the |
Yes, try it! I think I may have encountered this issue when I initially integrated CMSIS-DSP. Maybe we could also read the first few lines of the header file in Python and regex out the required defines. |
Hmm I've been playing around this and I've noticed that in some of the examples, they include both The regex thing could work, but it doesn't seem too nice for a long term solution. I wonder if we could design a better interface? Maybe write our own headers over top of the arm ones to ensure the include order is correct. Or, we could put the includes for everything into one I'm not 100% sure what the intended interface for the DSP extension is currently, so guidance here would be appreciated! |
I took another look at this and figured it out. I got confused last time, but moving the configuration into This should be good to go now 👍 |
846b412
to
a3ac5db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I rebased and squashed your commits)
Resolves #1181.
Let me know what you think about removing the previous defines, as mentioned here.