Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add driver for AB (incremental) encoder output #153

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Add driver for AB (incremental) encoder output #153

merged 2 commits into from
Jun 15, 2020

Conversation

rleh
Copy link
Member

@rleh rleh commented Jan 23, 2019 •
edited
Loading

This driver generates a AB (incremental) encoder signal to emulate a hardware encoder with a microcontroller.

  • Example
  • Test on real hardware
  • Add a higher-resolution (than 1ms) Timeout
  • Unittest?
  • Rename to EncoderOutput.

@salkinium
Copy link
Member

(also CI Caching doesn‘t work like I wanted it too, so the tests may take longer)

@rleh rleh force-pushed the feature/driver_encoder_slave branch 2 times, most recently from 0d12ce3 to 21297bb Compare January 23, 2019 01:39
@ekiwi
Copy link
Contributor

ekiwi commented Jan 23, 2019

Maybe you could change EncoderSlave to EncoderOutput.
Seems more descriptive to me.

@salkinium salkinium force-pushed the develop branch 2 times, most recently from 738dfa4 to 1b36326 Compare January 23, 2019 19:36
@rleh rleh changed the title Add driver for AB (incremental) encoder slave Add driver for AB (incremental) encoder output Jan 27, 2019
@rleh rleh force-pushed the feature/driver_encoder_slave branch from 21297bb to 2585e8d Compare January 27, 2019 23:37
salkinium
salkinium reviewed Jan 28, 2019
View reviewed changes
src/modm/architecture/interface/precision_clock.hpp Outdated Show resolved Hide resolved
src/modm/platform/clock/cortex/modm_precision_clock.cpp Outdated Show resolved Hide resolved
src/modm/processing/timer/periodic_timer.hpp Outdated Show resolved Hide resolved
src/modm/processing/timer/timestamp.hpp Outdated Show resolved Hide resolved
ekiwi
ekiwi reviewed Jan 29, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@rleh rleh force-pushed the feature/driver_encoder_slave branch from 2585e8d to f8c8dc1 Compare February 24, 2019 19:19
@salkinium salkinium force-pushed the develop branch 4 times, most recently from 3da698d to 01092cf Compare March 8, 2019 23:04
@salkinium salkinium mentioned this pull request Apr 4, 2019
Closed
@salkinium salkinium mentioned this pull request May 15, 2019
Merged
11 tasks
@rleh rleh force-pushed the feature/driver_encoder_slave branch from f8c8dc1 to 7df919e Compare June 14, 2020 02:55
@rleh rleh requested a review from salkinium June 14, 2020 02:57
@rleh rleh removed the stale ♾ label Jun 14, 2020
salkinium
salkinium requested changes Jun 14, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple driver!

examples/stm32f4_discovery/encoder_output/main.cpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/encoder_output.hpp Outdated Show resolved Hide resolved
src/modm/driver/encoder/encoder_output_impl.hpp Outdated Show resolved Hide resolved
@rleh rleh force-pushed the feature/driver_encoder_slave branch from 7df919e to 21af57b Compare June 14, 2020 15:46
@rleh
Copy link
Member Author

rleh commented Jun 14, 2020

encoder-output

@rleh rleh requested a review from salkinium June 14, 2020 16:10
salkinium
salkinium approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Do you want me to merge this now or wait until after you added unittests?

@rleh
Copy link
Member Author

rleh commented Jun 15, 2020

I do not plan to add unit tests in the near future, so I would suggest to merge this.

@salkinium salkinium merged commit 21af57b into modm-io:develop Jun 15, 2020
@rleh rleh deleted the feature/driver_encoder_slave branch June 15, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekiwi ekiwi ekiwi left review comments

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
advanced 🤯 feature 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleh @salkinium @ekiwi