Add minimal BNO055 driver #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
force-pushed
the
feature/bno055
branch
from
25c158d
to
b93e7ba
Compare
dergraaf
reviewed
Apr 10, 2019
| /// Constructor, requires a bno055::Data object. | ||
| /// For I2c this also sets the address to 0b110101 (alternative: 0x1C). | ||
| inline Bno055(Data &data, uint8_t address=addr()): | ||
| I2cDevice<I2cMaster,2>(address), data(data) {} |
There was a problem hiding this comment.
data(data) is very error prune, as the compiler will still be happy if you rename the argument but don't change this line. I suggest either an m prefix for the member (what I've been using lately) or an _ suffix for the parameter, that seem to be the most popular options. Or rename either of the two to something different.
There was a problem hiding this comment.
Yeah, I’d like to use the Qt coding conventions in general: m_ prefix and just obj.data() as getter. But, yeah, conventions…
salkinium
force-pushed
the
feature/bno055
branch
2 times, most recently
from
38f8ebc
to
b562393
Compare
salkinium
force-pushed
the
feature/bno055
branch
from
b562393
to
f160997
Compare
salkinium
force-pushed
the
feature/bno055
branch
from
f160997
to
a8edbe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a minimal implementation of the BNO055 driver, which only reads the results array in full NDOF mode.