Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nucleo f446 #228

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Feature/nucleo f446 #228

merged 3 commits into from
Jun 20, 2019

Conversation

se-bi
Copy link
Contributor

@se-bi se-bi commented Jun 18, 2019

Do you want it besides rebased also squashed into one commit?

@salkinium
Copy link
Member

Something like 3 commits would be nice:

  1. Add board
  2. Add example
  3. Add test

@salkinium
Copy link
Member

CI will start for the next push, I experimented with something that didn't work in the config.

@se-bi se-bi force-pushed the feature/nucleo-f446 branch 3 times, most recently from f4cf58a to 581d54b Compare June 20, 2019 09:05
@se-bi
Copy link
Contributor Author

se-bi commented Jun 20, 2019

Finally,
script checking the doc is also happy

salkinium
salkinium previously approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@se-bi
Copy link
Contributor Author

se-bi commented Jun 20, 2019

Now, that CI verified,
might not be integrated in the CI run itself 🙈

@salkinium
Copy link
Member

salkinium commented Jun 20, 2019 •
edited
Loading

Also add the unittest run. kinda redundant.

@strongly-typed strongly-typed mentioned this pull request Jun 20, 2019
Closed
@salkinium salkinium merged commit 9381fd0 into modm-io:develop Jun 20, 2019
@se-bi se-bi deleted the feature/nucleo-f446 branch June 21, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium left review comments

Assignees
No one assigned
Labels
feature 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@se-bi @salkinium