Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openocd] Do not hardcode user options in built-in configs #240

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

salkinium
Copy link
Member

The modm board configurations hard-coded the programmer, which is an issue when using a different one.

This replaces #235 and fixes #234 and fixes #238.

cc @asmfreak

@salkinium
Copy link
Member Author

@asmfreak I think the PR is a fix for both your issues and should allow future customization for these situations. Can you check if this works for you?

@salkinium
Copy link
Member Author

@asmfreak Ok with you to merge this?

Copy link
Contributor

@asmfreak asmfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is going

src/modm/board/black_pill/module.lb Show resolved Hide resolved
@salkinium salkinium force-pushed the fix/openocd_programmer branch 2 times, most recently from 3b56f30 to afbd533 Compare July 11, 2019 03:44
The modm board configurations hard-coded the programmer, which is an
issue when using a different one.
Copy link
Contributor

@asmfreak asmfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@salkinium salkinium merged commit afbd533 into modm-io:develop Jul 11, 2019
@salkinium salkinium mentioned this pull request Jul 11, 2019
@salkinium salkinium deleted the fix/openocd_programmer branch July 23, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for chinese STM32F103C8T6 clones Bluepill cannot be programmed with stlink v2.1
2 participants