Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf24] Update driver and examples #253

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Jul 23, 2019

This imports the updated driver code from the R2MAC project.

  • Import code
  • cleanup code (static inline, don't overwrite log level)
  • Update copyright
  • Update examples and validate in hardware

cc @daniel-k @squarecode

@salkinium salkinium force-pushed the feature/nrf24_update branch 2 times, most recently from 6b55bed to af61faa Compare July 24, 2019 17:19
@salkinium salkinium merged commit 22867e0 into modm-io:develop Jul 24, 2019
@salkinium salkinium deleted the feature/nrf24_update branch July 24, 2019 18:15
@daniel-k
Copy link
Contributor

Woohoo, nice! \o/

@salkinium
Copy link
Member Author

Woohoo, nice! \o/

I still want to add the R2MAC, but I couldn't decide at the time if it should be put into modm/communication or into its own repo (like the invensese eMD). A modm:communication:r2mac module sounds good tho.

@daniel-k
Copy link
Contributor

Feel free to choose to your preferences. Open-sourcing R2MAC has always been my goal, but I never got there. Since it's quite strongly tied to the nrf24 driver in modm, there's no use beyond modm, so both options seem fine to me. However, the code is still ... well you probably know 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants