Added NACKIE flag to read and write operations #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there also a NACKIE that needs to be enabled for the non-extended STM32 driver? |
I haven't checked that. I'm currently working only with the STM32F042K6. I'll check this later tonight on on a STM32F411 board |
|
The problem on getting the system stuck when trying to read from I2C nodes that don't respond does not appear on the non-extended master driver. So no need to change on that part. |
|
Great! Can you rebase your commit so I can fast forward develop? |
nesos
force-pushed
the
fix/i2c-missing-nackie
branch
from
4dd5d5c
to
c04e6a4
Compare
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read and write operations are missing the NACK interrupt enable flag. This causes devices to be trapped in an endless loop when the addressed device is not responding.
In this case no interrupt will be raised, the transaction will not be detached and stays busy forever.
I enabling the NACK interrupt when starting the transaction is fixing this issue