Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext] Update submodules, use full target identifiers #306

Merged
merged 4 commits into from
Oct 20, 2019

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Oct 19, 2019

modm-devices recently upgraded it's device identifiers to untangle some more merged devices.
This requires specifying the additional identifiers of the device.
All other submodules were upgraded too, with some significant additions to CMSIS-DSP.

TODO:

  • Adapt for CMSIS-DSP additions.
  • Modify compile-all tests to not compile devices that only differ in temperature rating (like stm32f407vtg6 vs stm32f407vtg7)
  • Modify generate_module_docs.py to ignore temperature key for STM32 and package for AVR to keep RAM usage in check for CI.
  • Subclass EnumerationOption to allow longer than required identifiers (stm32f407vtg6u vs. required stm32f407vtg6) to allow people to simply enter the code that's laser engraved on the actual chip. Give a better error message when input string is too short.

cc @rleh @chris-durand

- Allows use of longer than necessary target identifiers.
- Returns a list of ambiguous targets when input is too short.
@salkinium
Copy link
Member Author

Example error message for target string too short:

 $ lbuild build

ERROR: Configuration(../../../src/modm/board/disco_f469ni/board.xml): Failed to validate Option!
TargetOption(modm:target): input 'stm32f469nih' is invalid! Ambiguous target!
Multiple devices found:

    - stm32f469nih6
    - stm32f469nih7

>> modm:target  [TargetOption]

Meta-HAL target device

Value: REQUIRED
Inputs: [at90can128-16ai, at90can128-16au, at90can128-16mi, ...

Unknown target:

 $ lbuild build

ERROR: Configuration(../../../src/modm/board/disco_f469ni/board.xml): Failed to validate Option!
TargetOption(modm:target): input 'blub' is invalid! Target is unknown!

>> modm:target  [TargetOption]

Meta-HAL target device

Value: REQUIRED
Inputs: [at90can128-16ai, at90can128-16au, at90can128-16mi, ...

@salkinium salkinium merged commit 62ccc26 into modm-io:develop Oct 20, 2019
@salkinium salkinium deleted the feature/full_identifiers branch October 20, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant