[stm32] Clock: pass pll factors as struct #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
requested changes
Mar 19, 2020
rleh
force-pushed
the
pll_factors_struct
branch
from
514b290
to
a04569f
Compare
|
Dang, I just merged the assert PR, before checking this one, sorry. |
salkinium
approved these changes
Mar 19, 2020
rleh
force-pushed
the
pll_factors_struct
branch
from
a04569f
to
e3ba913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it more difficult to pass the Pll factors incorrectly, which was previously easily possible with the position-based arguments.
Old API is marked as
[[deprecated]], but still works.