Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Nucleo F042K6 #43

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Added support for Nucleo F042K6 #43

merged 1 commit into from
Jul 28, 2018

Conversation

cajt
Copy link
Contributor

@cajt cajt commented Jul 26, 2018

It is based on the BSP for Nucelo F031.
Testing is mostly incomplete. I only tested: USART1 & USART2 as loggers, LED blinking.
Basically, I fiddled the clock generation to make the USARTs work, and fixed things along the way.

salkinium
salkinium previously approved these changes Jul 27, 2018
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

Can you rebase your commit on top of the current develop?
Unfortunately you didn't use a feature branch, so if I did the cherry-pick for you and force pushed this to your develop branch, it would be out of sync with your local branch.
I wish there was a GitHub option to prevent pull requests on the develop Branch.

salkinium
salkinium previously approved these changes Jul 28, 2018
@salkinium
Copy link
Member

ProTip: Don't review late at night. I modified some things incl. adding the example into the CI.

It is based on the BSP for Nucelo F031.
Testing is mostly incomplete. I only tested: USART1 & USART2 as loggers, LED blinking.
Basically, I fiddled the clock generation to make the USARTs work, and fixed things along the way.
@salkinium salkinium merged commit fd7b7a3 into modm-io:develop Jul 28, 2018
@salkinium
Copy link
Member

FYI: I force pushed the develop branch to your repo, you'll need to git reset --hard origin/develop on your local machine. Please use a feature/name branch in future to avoid getting develop out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants