[board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 #437

asmfreak · 2020-07-19T19:25:50Z

This PR add support for this board.

board.hpp actually works (ported from disco_f407vg board)
Examples ported
- Blink ex
- Uart works
- LCD Display works (requires new functionality for ILI9341 in ParallelDisplay module).
- Touch screen works
- On-board memory unit works

salkinium · 2020-07-20T07:51:21Z

examples/stm32_f4ve/gui/touchscreen_calibrator.hpp

+	// E��((X0��X2) (YD1��YD2)��(YD0��YD2) (X1��X2))��K	*/
+	En =	((sample[0].x - sample[2].x) * (display[1].y - display[2].y)) -
+			((display[0].y - display[2].y) * (sample[1].x - sample[2].x));
+	// F��(Y0(X2YD1��X1YD2)+Y1(X0YD2��X2YD0)+Y2(X1YD0��X0YD1))��K */


Encoding issues…

This is very strange. I've copied it from another example.

Welp. Encoding is broken in examples/stm32f4_discovery/open407v-d/gui/touchscreen_calibrator.hpp.

I think this file should be part of the :ui:display module, so it can be reused by everyone.

I agree. We just need to fix the encoding somehow.

salkinium · 2020-07-20T07:52:47Z

Nice! Are you sure you want to port all this functionality at once? I would recommend breaking it down into multiple PRs. Things like SD-Card support probably need a little more work since our FatFS implementation needs to be replaced, etc.

asmfreak · 2020-07-20T12:44:03Z

Since I want to experiment with all possible things, maybe I should convert this PR into an issue, and work it from there?
I was hoping to get support for the screen (ILI9341), but it is still lacking, which, I guess, will be a separate PR.

salkinium · 2020-07-20T12:48:37Z

maybe I should convert this PR into an issue, and work it from there?

It's fine, the difference between issue and PR is superficial. I just thought it might be easier to do it bit by bit, but it doesn't really matter that much.

mikewolfram · 2020-07-20T18:33:05Z

Since I want to experiment with all possible things, maybe I should convert this PR into an issue, and work it from there?

I was hoping to get support for the screen (ILI9341), but it is still lacking, which, I guess, will be a separate PR.

I have IlI9341 implemented and working. Could submit it when returned from vacation.

salkinium · 2020-09-07T19:04:01Z

Any updates on this?

asmfreak · 2020-09-13T09:50:11Z

@mikewolfram I've added ILI9341 support here. Maybe your code could improve my rather crude version?

mikewolfram · 2020-09-13T11:05:21Z

@mikewolfram I've added ILI9341 support here. Maybe your code could improve my rather crude version?

Sorry, had no time to finish it. I opened a draft PR so you can compare: #464. Wanted to improve it to support other interfaces than SPI too.

asmfreak · 2020-09-17T10:03:38Z

I've merged #464 here and improved by adding parallel interface to it.
@mikewolfram Is it ok with you?

asmfreak · 2020-09-17T16:02:09Z

@salkinium Can you please point me to docs on how to properly add a new board to modm?
I guess one should edit some Makefiles to point build system towards new board/examples?

salkinium · 2020-09-17T16:06:43Z

Can you please point me to docs on how to properly add a new board to modm?

Yes: https://modm.io/reference/module/modm-board/

I guess one should edit some Makefiles to point build system towards new board/examples?

No, a board is just an lbuild config + module, and gets auto-discovered inside the modm/board folder.
The way you did it with your board looks just fine, is it not working correctly?

salkinium · 2020-09-17T16:07:59Z

Ah, you probably mean to the modm CI?

Just add the example folder name to the right list here: https://github.com/modm-io/modm/blob/develop/.circleci/config.yml#L131

asmfreak · 2020-09-17T16:24:47Z

I'll test SD card, NRF24 and CAN support examples later.

salkinium · 2020-09-17T17:51:56Z

(I misconfigured the CircleCI reporters, but it's fixed on the next push)

salkinium · 2020-09-17T21:31:26Z

If you are adding all the .pbm files to the repository, it would make sense to make them part of the :ui:display module: https://github.com/modm-io/modm/tree/develop/src/modm/ui/display/image

salkinium

Where do the images come from and what licence do they have? If they're compatible I'd like to see them moved into the library for reuse.

I'm going to adapt the ILI9341 driver just a little bit to our coding style. It's easier this way than to review it.

salkinium · 2020-09-17T21:43:40Z

examples/stm32_f4ve/gui/main.cpp

+		// tft.drawImage(pixPos, pix);
+	}
+
+	return 0;


Why is

there

so much

space in this

function?

😜

salkinium · 2020-09-17T21:45:31Z

examples/stm32_f4ve/gui/touchscreen_calibrator.hpp

+	// E��((X0��X2) (YD1��YD2)��(YD0��YD2) (X1��X2))��K	*/
+	En =	((sample[0].x - sample[2].x) * (display[1].y - display[2].y)) -
+			((display[0].y - display[2].y) * (sample[1].x - sample[2].x));
+	// F��(Y0(X2YD1��X1YD2)+Y1(X0YD2��X2YD0)+Y2(X1YD0��X0YD1))��K */


I think this file should be part of the :ui:display module, so it can be reused by everyone.

examples/stm32_f4ve/gui/images/.gitignore

asmfreak · 2020-09-18T00:53:06Z

examples/stm32_f4ve/gui code and images are coming from another example examples/stmf4_discovery/open407v-d/gui. So any questions concerning file encodings and image files licenses are to be asked about that example too. I've just copied that example to stm32_f4ve's folder and edited a bit to make it compile and run on this board.

asmfreak · 2020-09-19T14:05:32Z

@salkinium What is my next step on this PR? Please advise.

salkinium · 2020-09-19T14:21:57Z

If you are motivated, you could move all .pbm images inside the examples into the :display module.

But since I'm not super aware of the :display and :ui modules, since they were written almost exclusively by @dergraaf and @daniel-k, we can also just merge this as is, and sort this out later. I was mainly just concerned about repo size, but since these files are already in the repo, it doesn't matter much.

salkinium · 2020-09-19T14:24:48Z

If you're not motivated, that's fine too (your contributions are more important than this optimization), then I'll squash the branch and fix commit structure to match our style.

asmfreak · 2020-09-19T14:27:59Z

I think that :display and :ui modules refactoring should take place in another PR with proper discussion with @dergraaf and @daniel-k . I'd prefer for this PR to be merged as is.

examples/stm32_f4ve/flash/project.xml

examples/stm32_f4ve/gui/project.xml

examples/stm32_f4ve/gui/touchscreen_calibrator.hpp

rleh

Nice!
I ordered the Board & Display, looking forward to play with it (when it arrives in a few weeks).

salkinium · 2020-09-19T14:50:22Z

Ok, I'll rebase/squash/restructure and adapt for @rleh's review.

asmfreak · 2020-09-19T14:51:41Z

Nice!

Co-authored-by: delphi <cpp.create@gmail.com>

salkinium · 2020-09-19T16:48:04Z

Just restructured logically, and added shared author-ship on IL9341 driver.

mikewolfram · 2020-09-20T14:25:47Z

src/modm/driver/display/ili9341_spi.hpp

+			if (i.releaseMaster())
+				Cs::set();
+		}
+	};


Does it really make sense to pass the SPI interface every time? Wouldn't it be better to do like:

struct BatchHandle { BatchHandle() { SPI::acquireMaster(); Cs::reset(); } ~BatchHandle() { if (SPI::releaseMaster()) Cs::set(); } };

And maybe the name AcquireInterface is more intuitive to BatchHandle?

My few cents...

Yes probably. However the compiler will inline all of this anyways. Feel free to change this if you feel strongly about it.

asmfreak marked this pull request as draft July 19, 2020 19:26

asmfreak marked this pull request as ready for review July 19, 2020 19:26

asmfreak marked this pull request as draft July 19, 2020 19:27

salkinium added advanced 🤯 feature 🚧 labels Jul 20, 2020

salkinium reviewed Jul 20, 2020

View reviewed changes

asmfreak force-pushed the feature/add_board_stm32_f4ve branch from d7f471b to f538842 Compare September 13, 2020 09:43

asmfreak force-pushed the feature/add_board_stm32_f4ve branch 2 times, most recently from 78607cd to 1a22120 Compare September 13, 2020 10:20

asmfreak force-pushed the feature/add_board_stm32_f4ve branch from 1a22120 to 638d3f3 Compare September 17, 2020 10:02

asmfreak force-pushed the feature/add_board_stm32_f4ve branch from 638d3f3 to 3306ef7 Compare September 17, 2020 10:09

asmfreak marked this pull request as ready for review September 17, 2020 16:25

asmfreak changed the title ~~[board] Add basic support for STM32_F32VE board~~ [board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 Sep 17, 2020

salkinium reviewed Sep 17, 2020

View reviewed changes

rleh reviewed Sep 19, 2020

View reviewed changes

examples/stm32_f4ve/flash/project.xml Show resolved Hide resolved

rleh reviewed Sep 19, 2020

View reviewed changes

examples/stm32_f4ve/gui/project.xml Outdated Show resolved Hide resolved

rleh reviewed Sep 19, 2020

View reviewed changes

examples/stm32_f4ve/gui/touchscreen_calibrator.hpp Outdated Show resolved Hide resolved

rleh reviewed Sep 19, 2020

View reviewed changes

examples/stm32_f4ve/gui/touchscreen_calibrator.hpp Show resolved Hide resolved

rleh approved these changes Sep 19, 2020

View reviewed changes

asmfreak added 2 commits September 19, 2020 18:44

[board] Add STM32_F32VE board support package

7ef59a7

[examples] Add W25Q16 external Flash example

a5b1d9e

salkinium force-pushed the feature/add_board_stm32_f4ve branch from f1e3d42 to 4e59aa3 Compare September 19, 2020 16:47

[display] Add ILI9341 Parallel/SPI display driver

9263e8d

Co-authored-by: delphi <cpp.create@gmail.com>

salkinium force-pushed the feature/add_board_stm32_f4ve branch from 4e59aa3 to a6f1186 Compare September 19, 2020 16:50

salkinium approved these changes Sep 19, 2020

View reviewed changes

[examples] Add ILI9341 display example

a6f1186

salkinium mentioned this pull request Sep 19, 2020

Ili9341 support (SPI only). #464

Closed

salkinium merged commit a6f1186 into modm-io:develop Sep 19, 2020

asmfreak deleted the feature/add_board_stm32_f4ve branch September 19, 2020 17:19

mikewolfram reviewed Sep 20, 2020

View reviewed changes

mikewolfram mentioned this pull request Sep 26, 2020

Ili9341 SPI not compiling #483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 #437

[board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 #437

asmfreak commented Jul 19, 2020 •

edited

Loading

salkinium Jul 20, 2020

asmfreak Jul 20, 2020

asmfreak Jul 20, 2020

salkinium Sep 17, 2020

asmfreak Sep 18, 2020

salkinium commented Jul 20, 2020

asmfreak commented Jul 20, 2020

salkinium commented Jul 20, 2020

mikewolfram commented Jul 20, 2020

salkinium commented Sep 7, 2020

asmfreak commented Sep 13, 2020

mikewolfram commented Sep 13, 2020

asmfreak commented Sep 17, 2020

asmfreak commented Sep 17, 2020 •

edited

Loading

salkinium commented Sep 17, 2020

salkinium commented Sep 17, 2020

asmfreak commented Sep 17, 2020

salkinium commented Sep 17, 2020

salkinium commented Sep 17, 2020

salkinium left a comment

salkinium Sep 17, 2020

salkinium Sep 17, 2020

asmfreak commented Sep 18, 2020

asmfreak commented Sep 19, 2020

salkinium commented Sep 19, 2020

salkinium commented Sep 19, 2020

asmfreak commented Sep 19, 2020

rleh left a comment

salkinium commented Sep 19, 2020

asmfreak commented Sep 19, 2020

salkinium commented Sep 19, 2020

mikewolfram Sep 20, 2020

salkinium Sep 20, 2020

[board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 #437

[board] Add basic support for STM32_F32VE board and [driver] ILI9341 via #464 #437

Conversation

asmfreak commented Jul 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salkinium commented Jul 20, 2020

asmfreak commented Jul 20, 2020

salkinium commented Jul 20, 2020

mikewolfram commented Jul 20, 2020

salkinium commented Sep 7, 2020

asmfreak commented Sep 13, 2020

mikewolfram commented Sep 13, 2020

asmfreak commented Sep 17, 2020

asmfreak commented Sep 17, 2020 • edited Loading

salkinium commented Sep 17, 2020

salkinium commented Sep 17, 2020

asmfreak commented Sep 17, 2020

salkinium commented Sep 17, 2020

salkinium commented Sep 17, 2020

salkinium left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmfreak commented Sep 18, 2020

asmfreak commented Sep 19, 2020

salkinium commented Sep 19, 2020

salkinium commented Sep 19, 2020

asmfreak commented Sep 19, 2020

rleh left a comment

Choose a reason for hiding this comment

salkinium commented Sep 19, 2020

asmfreak commented Sep 19, 2020

salkinium commented Sep 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmfreak commented Jul 19, 2020 •

edited

Loading

asmfreak commented Sep 17, 2020 •

edited

Loading