Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpi] Adds basic support for GPIO on Raspberry Pi boards #444

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

henrikssn
Copy link
Contributor

@henrikssn henrikssn commented Aug 14, 2020

The purpose of this is to simplify driver development, using bitbang SPI&I2C on the RPi.

It is essentially just a wrapper around WiringPi.

salkinium
salkinium previously approved these changes Aug 14, 2020
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I didn't expect so few changes to get this to work, but then again Linux is doing all the heavy lifting here.

tools/devices/hosted/rpi.xml Outdated Show resolved Hide resolved
@henrikssn
Copy link
Contributor Author

Nice job! I didn't expect so few changes to get this to work, but then again Linux is doing all the heavy lifting here.

Thanks! Yeah, it is mostly Linux and WiringPi which solved the hard stuff, this is mostly a wrapper... Anyway, I tested the BitBangSPI implementation with this and that worked fine. Might be the easiest way to run hardware driver tests (if we ever get to setting up a CI for that)

@rleh
Copy link
Member

rleh commented Aug 19, 2020

https://circleci.com/gh/modm-io/modm/20845:

python3 tools/scripts/synchronize_docs.py -d

git diff
diff --git a/README.md b/README.md
index 79a9df804..eaf76f7d4 100644
--- a/README.md
+++ b/README.md
@@ -157,6 +157,7 @@ documentation.
 <td align="center">NUCLEO-L476RG</td>
 <td align="center">OLIMEXINO-STM32</td>
 </tr><tr>
+<td align="center">RASPBERRYPI-4</td>
 <td align="center">SAMD21-MINI</td>
 <td align="center">STM32F030F4P6-DEMO</td>
 </tr>

Please synchronize the modm documentation:

    $ python3 tools/scripts/synchronize_docs.py

and then commit the results!

@salkinium salkinium dismissed their stale review August 26, 2020 02:21

Changes required

@henrikssn
Copy link
Contributor Author

Ready to merge

@rleh
Copy link
Member

rleh commented Sep 7, 2020

Could you squash and rebase your commits?

@salkinium
Copy link
Member

I’ll rebase/merge it later.

@salkinium
Copy link
Member

I’ll rebase/merge it later.

Restructured commits and fixed a small refactoring bug, I'll merge once the CI passes.

@salkinium salkinium merged commit d3496a3 into modm-io:develop Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants