First implementation of Ethernet for STM32F7 (and later STM32F4). #466

mikewolfram · 2020-09-14T18:28:36Z

Et voila, here we go. This is the code I currently use plus an example for F767ZI Nucleo board. The example is a quick hack of code I already use.

Quite a few things to do, e.g. the module.lb file is missing. Also the network interface file for FreeRTOS might need a better location. And in it there is hardcoded LAN8720 PHY. I was thinking to make that an option in the XML or required the use to create an include file with the proper declaration.

Let's start from here, any help is appreciated. I'm a bit short of time until the end of the year, but together we should be able to get it done.

mikewolfram · 2020-09-14T18:29:30Z

Wanted to make it a draft PR, any way to change it? Or delete and recreate?

strongly-typed · 2020-09-16T18:42:29Z

ERROR: Cannot resolve name 'modm:platform:eth' of type Module!

Could you please also make your modm module available? Thank you!

mikewolfram · 2020-09-16T19:17:55Z

Could you please also make your modm module available? Thank you!

As of now I don't have a module file. Before opening the PR I had those files in my sources, I copied them to that location for the PR. So even with a module file I expect them to not compile as the includes etc. won't work.

Sorry for that. Right now I'm hacking together (is this real English? :-) ) a proof of concept while throwing away whatever I learned about software development, coding style etc.

Working 11-12 hours a day, 11 days in a row and living in a hotel isn't so much fun. :-( Let's see what I could for you...

mikewolfram · 2020-09-16T19:20:00Z

And without a separate project I cannot event run "lbuild" as it would overwrite changes I made to some files. :-( I know, I completely messed it up.

salkinium · 2020-09-16T19:22:18Z

Please don't burn yourself out!

(Sascha is also capable of adding a suitable module.lb himself *wags finger like a mom*)

mikewolfram · 2020-09-16T19:28:53Z

Please don't burn yourself out!

I'm already beyond a burnout... :-)

(Sascha is also capable of adding a suitable module.lb himself wags finger like a mom)

Sure he can, but he's afraid to destroy my genius work. :-)
(Sorry, couldn't resist).

strongly-typed · 2020-09-17T08:06:54Z

Take your time! I am just curious in bringing Ethernet support to modm. I have no deadlines nor customers involved with this topic. I have a Nucleo F429ZI (which claims to have Ethernet) for further testing and maybe I can help with your current memory problems.

mikewolfram · 2020-09-18T15:34:32Z

I have a few days off and won't be touching any keyboard...

The F4 series might be a bit different to the F7 in regards to ethernet. I used the FreeRTOS network interface for STM32 HAL as example and stripped off things. There are a few places where they differ between F4 and F7. They also provide a modified version of the HAL_ETH files. Maybe you want to have a look to get an idea what is the actual difference.

More to come next week.

mikewolfram · 2020-09-26T18:15:47Z

I have updated with the latest from develop, don't know why all the commits are showing up here now. Did I screw something up?

Still investigating the memory issue. I have a feeling, that the stack of the IPTask might get corrupted. In my driver I send an event with the network descriptor pointer, which is always in the range 0x20013000 to 0x20015000. Had a hard fault, where the received event had a pointer of 0x2002ba24. Increased the stack from 640 to 1024 words, let's see if that changes anything.

The other tasks in theory should not be able to modify the IPTask stack, but you never know. I have a very simple task that only toggles a LED every second, even that one needs more than the minimal 128 words for the stack. Set it to 256 words and it is now running.

mikewolfram · 2020-09-26T19:37:05Z

And another question. I saw that you moved a few files in FreeRTOS_TCP. When I added it I had a rather simple directory layout, but maybe it would make sense to move the headers into a freertos_tcp folder like freertos?

salkinium · 2020-09-26T20:00:00Z

Delegating to @strongly-typed.

mikewolfram · 2020-09-29T19:48:55Z

Short question, one example is failing, because it is complaining about a symbol defined in stm32f765xx.h. I thought this would be included before? Or did I miss something?

src/modm/platform/eth/stm32/module.lb

strongly-typed · 2020-10-02T21:23:09Z

And another question. I saw that you moved a few files in FreeRTOS_TCP. When I added it I had a rather simple directory layout, but maybe it would make sense to move the headers into a freertos_tcp folder like freertos?

I had duplicated includes so I only copied the needed files. Yes, a subdirectory would make perfect sense.

(I do not know if there are any dependencies at FreeRTOS that require the files to be in one directory.)

mikewolfram · 2020-10-08T19:53:53Z

Looks like the code is running fine now. Maybe the fix to drop invalid frames was the issue? That would explain why it was working fine on an isolated network, but crashed on a busy network in the office?

mikewolfram · 2021-02-03T23:10:37Z

I wasn't aware this is still a draft and was wondering why we didn't get any further. I turned the status to "Ready for review", so let's discuss what is needed to finally merge it (e.g. lack of documentation).

We have the code running for several months now, with no major problems (still don't know if this is a bug in the implementation or the result of some crazy network setup in the company).

rleh · 2021-02-04T06:55:07Z

I don't know what happened with the MacOS CI, but it is now fixed (by re-running the job).
I will do a review later today!

src/modm/platform/eth/stm32/eth.hpp

rleh

I made a few minimal changes in 10a4cff (remove commented-out code and inline some static variables), otherwise looks very good!

rleh · 2021-02-11T12:05:24Z

I can confirm, that

the blink/-example works on hardware
the ethernet/-example does not work. 😒

The logger just outputs Reboot: Ethernet Example and then nothing happens. The LEDs on the ethernet jack light up once I plug in a cable.

mikewolfram · 2021-02-11T12:20:36Z

Thanks for testing. Let's find out what is different to my custom board and what might be wrong.

Did you check with the debugger what is causing the reboot? Maybe the stack needs to be increased?

rleh · 2021-02-11T12:39:30Z

For some reason GDB does not work on my computer, i'm working on it...

Compiling in debug mode (scons profile=debug) tells me the following:

Reboot: Ethernet Example
Assertion 'eth.init' @ 0x00000001 (1) failed!
  ETH::initialize() timed out on software reset!
Abandoning...

src/modm/platform/eth/stm32/eth.hpp

rleh

Successfully tested on hardware.

Thanks!!

rleh · 2021-02-11T13:26:43Z

Ping and www are good?

No. 😒
I was a bit hasty and accidentally pinged another device on the network.

rleh · 2021-02-11T13:43:21Z

Code runs until

while (true) {
  connectedSocket = FreeRTOS_accept(listeningSocket, &clientAddress, 0);
//...

but never seems to receive a connection.

I'll look at this further later.

kikass13 · 2021-02-18T13:03:03Z

ping and http work for me on a nucleo F767ZI, after correcting two pins for the phy.

change https://github.com/modm-io/modm/pull/466/files#diff-06b49187e6be0cc40e1894bf66bfb208da0a12b739e4d973f72e4a26bdf74ccfR25-R26

using RMII_Tx_En = GpioOutputB11;
using RMII_Tx_D0 = GpioOutputB12;

to

using RMII_Tx_En = GpioOutputG11;
using RMII_Tx_D0 = GpioOutputG13;

rleh · 2021-02-18T13:19:07Z

I applied @kikass13 fix, syncronized the docs and rebased onto current develop.
Thanks @kikass13 for finding the error!

@salkinium Are you ok with merging (after CI has finished)?

rleh

Tested: Ping and HTTP work ✔️

salkinium

🚢 it

salkinium · 2021-02-18T16:07:55Z

Something in this PR broke the docs generator. *wags finger*

Generating documentation for stm32f207zgt7 ...
Error generating documentation for device stm32f207zgt7: 'NoneType' object is not subscriptable

kikass13 · 2021-02-18T16:11:04Z

Something in this PR broke the docs generator. wags finger

Generating documentation for stm32f207zgt7 ...
Error generating documentation for device stm32f207zgt7: 'NoneType' object is not subscriptable

someone was using a list iterator on an object without checking for None ... SHAME! :D

salkinium · 2021-02-18T16:14:57Z

I think… *takes a long bong hit*… we need a CI for our CI test coverage…

rleh · 2021-02-18T16:15:08Z

Something in this PR broke the docs generator. wags finger
Generating documentation for stm32f207zgt7 ...

... but 15 times, spread random across multiple STM32 sub-families.

And the test run of the docs.modm.io script was successful. Maybe related to #553?

salkinium · 2021-02-18T16:16:18Z

It's probably something stupid, I'll check it out later.

rleh · 2021-02-21T13:13:00Z

It's probably something stupid, I'll check it out later.

Did you find out anything?
I just restarted the last successful build on CircleCI (without ethernet merged) to fix the 404 errors on https://docs.modm.io/...

salkinium · 2021-02-21T14:57:57Z

I forgot, but it was something very stupid, so I found it very quickly: #565

rleh · 2021-02-21T16:43:45Z

examples/nucleo_f767zi/ethernet/main.cpp

+		// initialize random numbers
+	    time_t now;
+	    time(&now);
+	    ulNextRand = uint32_t(now);


We could have used real random numbers here...

Suggested change

// initialize random numbers

time_t now;

time(&now);

ulNextRand = uint32_t(now);

// initialize random numbers

modm::platform::RandomNumberGenerator::enable();

while(!modm::platform::RandomNumberGenerator::isReady()) {}

ulNextRand = modm::platform::RandomNumberGenerator::getValue();

Yes, and as a fallback you can seed srand with the device's UID.

Also time() is not implemented. We could perhaps wire it to modm::Clock, but it's not done yet.

Yes, and as a fallback you can seed srand with the device's UID.

I am not sure if this is a good idea or a serious security flaw...

Well, you need to collect entropy somehow. There are a bunch more hardware calibration registers that provide entropy within some bounds. It's a somewhat good idea since the values will be different for every device (assuming a good hash function), however, only if the attacker cannot read them out remotely. However, security is definitely beyond the scope of modm and too much work to implement yourself. We'd have to integrate some embedded TLS library for encryption.

mikewolfram mentioned this pull request Sep 14, 2020

Ethernet support / FreeRTOS+TCP #447

Closed

salkinium marked this pull request as draft September 14, 2020 19:09

salkinium added advanced 🤯 feature 🚧 labels Sep 14, 2020

mikewolfram force-pushed the ethernet branch 2 times, most recently from 4c71bae to 44d89dd Compare September 26, 2020 18:06

salkinium assigned strongly-typed Sep 26, 2020

mikewolfram force-pushed the ethernet branch from 44d89dd to 56bb52a Compare September 29, 2020 18:56

salkinium reviewed Sep 29, 2020

View reviewed changes

src/modm/platform/eth/stm32/module.lb Show resolved Hide resolved

mikewolfram mentioned this pull request Jan 29, 2021

[board] Nucleo-F767ZI support #542

Closed

4 tasks

mikewolfram force-pushed the ethernet branch from e1ce7f2 to 62abf31 Compare February 1, 2021 21:49

mikewolfram marked this pull request as ready for review February 3, 2021 23:08

rleh reviewed Feb 4, 2021

View reviewed changes

src/modm/platform/eth/stm32/eth.hpp Outdated Show resolved Hide resolved

rleh approved these changes Feb 4, 2021

View reviewed changes

salkinium force-pushed the ethernet branch from 713ae30 to b9cdb26 Compare February 9, 2021 11:53

rleh reviewed Feb 11, 2021

View reviewed changes

src/modm/platform/eth/stm32/eth.hpp Show resolved Hide resolved

rleh force-pushed the ethernet branch from b9cdb26 to ae4033f Compare February 11, 2021 13:17

rleh approved these changes Feb 11, 2021

View reviewed changes

[board] Add NUCLEO-F767ZI BSP

a9caeed

rleh force-pushed the ethernet branch from ae4033f to 55f1190 Compare February 18, 2021 13:06

Mike Wolfram added 4 commits February 18, 2021 14:18

[driver] Add LAN8720a driver

f2ee867

[ethernet] Add STM32 peripheral driver

e45977b

[freertos] Add STM32 Ethernet port via LAN8720a

ddbd29f

[examples] Add FreeRTOS TCP Ethernet example

d8be0a2

rleh force-pushed the ethernet branch from 55f1190 to d8be0a2 Compare February 18, 2021 13:18

rleh approved these changes Feb 18, 2021

View reviewed changes

salkinium approved these changes Feb 18, 2021

View reviewed changes

rleh merged commit d8be0a2 into modm-io:develop Feb 18, 2021

rleh reviewed Feb 21, 2021

View reviewed changes

rleh mentioned this pull request Apr 16, 2021

Ethernet for STM32F4 #615

Merged

First implementation of Ethernet for STM32F7 (and later STM32F4). #466

First implementation of Ethernet for STM32F7 (and later STM32F4). #466

Conversation

mikewolfram commented Sep 14, 2020

mikewolfram commented Sep 14, 2020

strongly-typed commented Sep 16, 2020

mikewolfram commented Sep 16, 2020

mikewolfram commented Sep 16, 2020

salkinium commented Sep 16, 2020 • edited Loading

mikewolfram commented Sep 16, 2020 • edited Loading

strongly-typed commented Sep 17, 2020

mikewolfram commented Sep 18, 2020

mikewolfram commented Sep 26, 2020

mikewolfram commented Sep 26, 2020

salkinium commented Sep 26, 2020

mikewolfram commented Sep 29, 2020

strongly-typed commented Oct 2, 2020

mikewolfram commented Oct 8, 2020

mikewolfram commented Feb 3, 2021 • edited Loading

rleh commented Feb 4, 2021

rleh left a comment

Choose a reason for hiding this comment

rleh commented Feb 11, 2021

mikewolfram commented Feb 11, 2021

rleh commented Feb 11, 2021

rleh left a comment

Choose a reason for hiding this comment

rleh commented Feb 11, 2021

rleh commented Feb 11, 2021 • edited Loading

kikass13 commented Feb 18, 2021

rleh commented Feb 18, 2021

rleh left a comment

Choose a reason for hiding this comment

salkinium left a comment

Choose a reason for hiding this comment

salkinium commented Feb 18, 2021 • edited Loading

kikass13 commented Feb 18, 2021

salkinium commented Feb 18, 2021

rleh commented Feb 18, 2021

salkinium commented Feb 18, 2021

rleh commented Feb 21, 2021

salkinium commented Feb 21, 2021

rleh Feb 21, 2021

Choose a reason for hiding this comment

salkinium Feb 21, 2021

Choose a reason for hiding this comment

salkinium Feb 21, 2021

Choose a reason for hiding this comment

rleh Feb 21, 2021

Choose a reason for hiding this comment

salkinium Feb 21, 2021

Choose a reason for hiding this comment

salkinium commented Sep 16, 2020 •

edited

Loading

mikewolfram commented Sep 16, 2020 •

edited

Loading

mikewolfram commented Feb 3, 2021 •

edited

Loading

rleh commented Feb 11, 2021 •

edited

Loading

salkinium commented Feb 18, 2021 •

edited

Loading