Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nucleo-g431kb board #499

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Add nucleo-g431kb board #499

merged 2 commits into from
Nov 16, 2020

Conversation

mcbridejc
Copy link
Contributor

I needed a board definition for the nucleo-32 g431kb development board.

If you are interested in expanding the BSP collection, feel free to merge. If not, feel free to reject and I can just include into my project.

There are a couple pins that differ from the usual nucleo-32 pinouts (as defined in nucleo32_arduino.hpp) on this board

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll gladly merge with these minor changes.

(Please squash into one commit)

src/modm/board/nucleo_g431kb/module.lb Outdated Show resolved Hide resolved
src/modm/board/nucleo_g431kb/board.hpp Outdated Show resolved Hide resolved
src/modm/board/nucleo_g431kb/board.hpp Show resolved Hide resolved
@salkinium
Copy link
Member

There are a couple pins that differ from the usual nucleo-32 pinouts

Yes, I've been bitten by this too already. We really need to extend modm-devices with the nucleo board pinouts and generate this…

Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

I added a GpioUnused Button and an example, so it becomes part of the CI and doesn't get lost in future refactorings.

@salkinium salkinium merged commit 276f5b3 into modm-io:develop Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants