Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[driver] Add MMC5603NJ Compass driver #556

Merged
merged 3 commits into from
Feb 12, 2021
Merged

[driver] Add MMC5603NJ Compass driver #556

merged 3 commits into from
Feb 12, 2021

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Feb 11, 2021 •
edited
Loading

  1. Adds a driver for the cheapest and smallest compass on Digikey: the MMC5603NJ.
  2. Makes modm::ui::Animation virtual, so that it can be used for motor position animation.
  3. Fixes an issue with Apa102::getColor()

rleh
rleh requested changes Feb 12, 2021
View reviewed changes
src/modm/driver/inertial/mmc5603.hpp Show resolved Hide resolved
src/modm/driver/inertial/mmc5603.hpp Outdated Show resolved Hide resolved
src/modm/driver/inertial/mmc5603.hpp Outdated Show resolved Hide resolved
src/modm/driver/inertial/mmc5603.hpp Outdated Show resolved Hide resolved
src/modm/driver/inertial/mmc5603.lb Show resolved Hide resolved
@salkinium
Copy link
Member Author

salkinium commented Feb 12, 2021 •
edited
Loading

Still have to do:

  • Test the changes to mmc5603::Data class in hardware.

@salkinium salkinium merged commit fb2ff58 into modm-io:develop Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand requested changes

@rleh rleh rleh approved these changes

Assignees
No one assigned
Labels
enhancement 🌈 feature 🚧 fix 💎
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salkinium @rleh @chris-durand