Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate XPCC system_tools from :build:scons module #58

Merged
merged 5 commits into from
Aug 8, 2018

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Aug 8, 2018

This adds the submodule :communication:xpcc:generator which copies the tools/system_design python tools to generating the XPCC communication.

Before the :build:scons module copied these files iff the :build:scons:xpcc.source option was set, which was weird when using a custom SConscript, and having to set this to a dummy.xml to get these files copied.

This also fixes duplicate compilation of the generated XPCC sources.

  • Rename the system_design folder to something more xpcc related, xpcc_generator?
  • Rename the communication examples to xpcc.

cc @dergraaf @rleh @mhthies @chris-durand

@salkinium salkinium force-pushed the feature/xpcc_generator branch 3 times, most recently from 733525b to 2fb0fcd Compare August 8, 2018 15:30
Copy link
Member Author

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this.

@rleh
Copy link
Member

rleh commented Aug 8, 2018

But the CI job unittests is unhappy:

python2: can't open file 'tools/system_design/builder/system_layout.py': [Errno 2] No such file or directory

@salkinium
Copy link
Member Author

But the CI job unittests is unhappy

Too much renamin', too little ack-grep'in.

@salkinium
Copy link
Member Author

fatal error: error writing to /tmp/ccpawS2W.s: Cannot allocate memory

CircleCI sometimes fails to allocate enough memory.

Too many levels of symbolic links

And GitlabCI is weird too.

Le Sigh…

@salkinium salkinium merged commit be3a65a into modm-io:develop Aug 8, 2018
@salkinium salkinium deleted the feature/xpcc_generator branch August 8, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants