Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2021q1 release #597

Merged
merged 4 commits into from
Apr 1, 2021
Merged

2021q1 release #597

merged 4 commits into from
Apr 1, 2021

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Mar 29, 2021 •
edited
Loading

Let's start doing releases again.
We'll do this in a modular way and with some scripting support to generate the links and to copy all the modular changelogs into a large CHANGELOG.md file.

I've added the quarterly changelogs all the way back to the last xpcc release 2018q2:

  • 2021q1
  • 2020q4
  • 2020q3
  • 2020q2
  • 2020q1
  • 2019q4
  • 2019q3
  • 2019q2
  • 2019q1
  • 2018q4
  • 2018q3
  • Script to build whole changelog

Any opinions on the format (it's from xpcc)?

Closes #44.

cc @rleh @chris-durand @strongly-typed

@salkinium salkinium force-pushed the feature/2021q1 branch 3 times, most recently from aca9015 to 5197168 Compare March 29, 2021 23:42
@salkinium salkinium marked this pull request as ready for review March 29, 2021 23:43
@salkinium salkinium force-pushed the feature/2021q1 branch 2 times, most recently from f24dd93 to a52b312 Compare March 30, 2021 00:09
rleh
rleh reviewed Mar 30, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rleh
rleh approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ❤️

@rleh
Copy link
Member

rleh commented Mar 30, 2021

I would like to see a link to the changelog somewhere in the README.

@salkinium salkinium mentioned this pull request Mar 30, 2021
Merged
13 tasks
chris-durand
chris-durand approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@salkinium salkinium force-pushed the feature/2021q1 branch 2 times, most recently from 5363585 to 6f1d165 Compare March 30, 2021 18:17
salkinium
salkinium commented Mar 30, 2021
View reviewed changes
README.md
David Hebbeker ([\@dhebbeker](https://github.com/dhebbeker)),
Thorsten Lajewski ([\@TheTh0r](https://github.com/TheTh0r)),
Mike Wolfram ([\@mikewolfram](https://github.com/mikewolfram))
and [many more contributors][contributors].
Copy link
Member Author

@salkinium salkinium Mar 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continued discussion from #592 (comment):

I've made >20 the new cutoff and linked to the GitHub contributors page. It's arbitrary, but I also don't have a better way and also I don't really want to spend too much time on it. The releases/changelog explicitly call out the contributors again and also the individual contributions in the changelog.

@salkinium
Copy link
Member Author

salkinium commented Mar 30, 2021 •
edited
Loading

With some scripting and regex, we can now write the release notes in normal markdown and the links get automatically created for the CHANGELOG.md. This makes it so, so much easier to write the release notes.

The real cherry on top is that I can now simply copy-paste the release notes without any changes into the GitHub Release UI and it autolinks everything automagically with inline preview 🥰:

@salkinium salkinium force-pushed the feature/2021q1 branch 2 times, most recently from b10adc9 to af3e66e Compare March 31, 2021 04:08
@salkinium
Copy link
Member Author

Is there a use-case for having the commit sha available? To look something up in the Git history?

@salkinium
Copy link
Member Author

I'll merge this tonight and tag the release 2021q1.

@salkinium salkinium force-pushed the feature/2021q1 branch 2 times, most recently from 30c62b7 to 4774b14 Compare April 1, 2021 04:21
@chris-durand @salkinium
[stm32] Fix interrupt loop for uart with tx buffer but no rx buffer
963f5b1 
The RXNE interrupt was also enabled if only tx was buffered. The
controller gets stuck in an endless loop because the flag is never
acknowledged in the ISR.
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 1, 2021
@salkinium salkinium merged commit 057ce23 into modm-io:develop Apr 1, 2021
@salkinium salkinium deleted the feature/2021q1 branch June 22, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleh rleh rleh approved these changes

@chris-durand chris-durand chris-durand approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs documentation 📑 process 📊
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tags and Releases are missing.
3 participants
@salkinium @rleh @chris-durand