[driver] ADC ADS816x #796
Merged
[driver] ADC ADS816x #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rleh
commented
Dec 21, 2021
•
rleh
commented
- Driver
- Example
- Test on real hardware
rleh
force-pushed
the
feature/driver_ads816x
branch
from
6ded6b1
to
67590d6
Compare
rleh
force-pushed
the
feature/driver_ads816x
branch
2 times, most recently
from
2dd9f18
to
b38a815
Compare
|
I commented out the code for the auto sequence mode for now, because it does not seem to switch channels correctly. Ready to merge from my side. |
salkinium
requested changes
Dec 31, 2021
rleh
force-pushed
the
feature/driver_ads816x
branch
from
b38a815
to
177a53b
Compare
| using namespace std::chrono_literals; | ||
| RF_BEGIN(); | ||
|
|
||
| if (std::popcount(channelsBitmask) > N) { |
There was a problem hiding this comment.
Just a side-note, if you are ever implementing the auto conversion mode: The most sensible way to use span here would be a std::span<uint16_t> with a dynamic size and then have result.size() here instead of N. That way it would be a normal runtime parameter for the size. The check is at runtime anyway.
chris-durand
approved these changes
Dec 31, 2021
rleh
force-pushed
the
feature/driver_ads816x
branch
from
177a53b
to
f5641c7
Compare
|
Removed the unnecessary |
rleh
force-pushed
the
feature/driver_ads816x
branch
from
f5641c7
to
3ba71c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.