Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021q4 release #797

Merged
merged 3 commits into from
Jan 1, 2022
Merged

2021q4 release #797

merged 3 commits into from
Jan 1, 2022

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Dec 29, 2021

It's quarterly release time again! 2022-01-01 is the date.

  • Merge remaining PRs?
    • STM32H7 DMA
    • ADS816x
  • Update all submodules
  • Fix submodule issues
    • FreeRTOS 202112.00
    • ETL v20.22.0
    • TinyUsb v0.12.0
    • LVGL v8.1.0
    • modm-devices
    • sam cmsis headers
    • stm32 cmsis headers
  • Update release notes
  • Check for updated compilers
  • Hardware testing
  • Fix author.py script to detect Co-authored-by correctly. next time™

@salkinium
Copy link
Member Author

salkinium commented Dec 29, 2021

LVGL v8.1.0 issues:

modm/ext/lvgl/lvgl/src/extra/libs/qrcode/qrcodegen.c:856:13: error: comparison of integer expressions of different signedness: 'long int' and 'unsigned int' [-Werror=sign-compare]

modm/ext/lvgl/lvgl/src/core/lv_indev.c:412:21: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
  412 |         LV_LOG_INFO("%d key is pressed", data->key);
      |                     ^~~~~~~~~~~~~~~~~~~  ~~~~~~~~~
      |                                              |
      |                                              uint32_t {aka long unsigned int}

modm/ext/lvgl/lvgl/src/core/lv_indev.c:496:21: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
  496 |         LV_LOG_INFO("%d key is released", data->key);
      |                     ^~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~
      |                                               |
      |                                               uint32_t {aka long unsigned int}

modm/ext/lvgl/lvgl/src/core/lv_indev.c:745:25: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
  745 |             LV_LOG_INFO("button %d is pressed (x:%d y:%d)", data->btn_id, x, y);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~
      |                                                                 |
      |                                                                 uint32_t {aka long unsigned int}

modm/ext/lvgl/lvgl/src/core/lv_indev.c:748:25: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
  748 |             LV_LOG_INFO("button %d is released (x:%d y:%d)", data->btn_id, x, y);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~
      |                                                                  |
      |                                                                  uint32_t {aka long unsigned int}

FreeRTOS+TCP 202112.00 issues:

modm/ext/freertos_plus_tcp/FreeRTOS_TCP_WIN.c:1874:33: error: comparison of integer expressions of different signedness: 'int32_t' {aka 'long int'} and 'unsigned int' [-Werror=sign-compare]
 1874 |             if( pxWindow->lSRTT < winSRTT_CAP_mS )
      |                                 ^

@salkinium
Copy link
Member Author

salkinium commented Dec 29, 2021

@rleh if you have time until new year, could you test if the updated FreeRTOS+TCP is still working in hardware?

@chris-durand
Copy link
Member

@salkinium We should include #772 in the release. It fixes broken DMA data for a lot of devices.

@salkinium
Copy link
Member Author

I'll merge it tomorrow, so you're not stressed today.

@rleh
Copy link
Member

rleh commented Dec 31, 2021

@rleh if you have time until new year, could you test if the updated FreeRTOS+TCP is still working in hardware?

Compiles with 5ea28f9 and work on my Nucleo-F429ZI 👍🏽

I also opened a PR upstream (FreeRTOS/FreeRTOS-Plus-TCP#403), then hopefully we can remove the fix on our config file before 2022q1 release.

@rleh
Copy link
Member

rleh commented Dec 31, 2021

  • Hardware testing

Do you need help with that?

@salkinium
Copy link
Member Author

Yes, please, also if you could fix LVGL, I'm not motivated to do it. That would probably require applying a patch inside the submodule as done with FreeRTOS for example.

@salkinium
Copy link
Member Author

salkinium commented Dec 31, 2021

In general we should not apply the same flags for third-party code that we apply for modm code. The -Werror issues are annoying to fix in third party code, but with the current lbuild collector architecture, there is no (good, usable) way to group compile flags by "code owner", even though most build systems support it.
It's a also annoying to compile your own application code with these strict compile flags…

@chris-durand
Copy link
Member

Yes, please, also if you could fix LVGL, I'm not motivated to do it. That would probably require applying a patch inside the submodule as done with FreeRTOS for example.

As a quick workaround I modified the auto updater in modm-ext/lvgl to apply a patch to fix the errors. It's on a feature branch for now and I opened a PR:
https://github.com/modm-ext/lvgl-partial/pull/1/files

Locally it compiles for me.

@chris-durand
Copy link
Member

I can't test lvgl since I have no boards with a display with me.

@rleh
Copy link
Member

rleh commented Dec 31, 2021

I can't test lvgl since I have no boards with a display with me.

Tested: Works (on STM32F469 DISCO board) ✅

image

@rleh
Copy link
Member

rleh commented Dec 31, 2021

Hardware Tests

Nucleo-F103_A

Failed 18 of 2645 tests␊
FAIL!␊
Unittests (Dec 31 2021, 19:13:19)␊
Machine:  ...
User:     ...
Os:       Linux-5.15.11-200.fc35.x86_64-x86_64-with-glibc2.34␊
Compiler: arm-none-eabi-g++ 10.2.1␊
Local Git User:␊
...
Last Commit:␊
SHA:             d2ed678349c396c145bd8082ecc33c2e24c8a189␊
Abbreviated SHA: d2ed678349␊
Subject:         fixup: lvgl 8.1.0 compile errors␊
␊
Author:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
Committer:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
File Status:␊
Modified:  0␊
Added:     0␊
Deleted:   0␊
Renamed:   0␊
Copied:    0␊
Untracked: 0␊
␊
>>> ad7280a_test␊
>>> atomic_queue_test␊
>>> block_allocator_test␊
>>> bme280_test␊
>>> bmp085_test␊
>>> bounded_deque_test␊
>>> bounded_queue_test␊
>>> bounded_stack_test␊
>>> button_group_test␊
>>> button_test␊
>>> can_bit_timings_test␊
>>> can_lawicel_formatter_test␊
>>> can_message_test␊
>>> clock_test␊
>>> color_test␊
>>> delay_test␊
>>> doubly_linked_list_test␊
>>> drv832x_spi_test␊
>>> dynamic_array_test␊
>>> fiber_test␊
>>> flash_test␊
>>> gpio_sampler_test␊
Channel 0:␊
-1990512242␊
-1990512099␊
-1990447934␊
-1990383765␊
-1990319514␊
Channel 1:␊
-1990512241␊
-1990255346␊
-1990191183␊
-1990127024␊
-1990062865␊
FAIL: gpio_sampler_test:71 : -143 not in range [0,64000]␊
FAIL: gpio_sampler_test:72 : -64165 not in range [64000,70400]␊
FAIL: gpio_sampler_test:73 : -64169 not in range [64000,70400]␊
FAIL: gpio_sampler_test:74 : -64251 not in range [64000,70400]␊
FAIL: gpio_sampler_test:77 : -256895 not in range [256000,262400]␊
FAIL: gpio_sampler_test:78 : -64163 not in range [64000,70400]␊
FAIL: gpio_sampler_test:79 : -64159 not in range [64000,70400]␊
FAIL: gpio_sampler_test:80 : -64159 not in range [64000,70400]␊
>>> i2c_test␊
>>> io_stream_test␊
>>> linked_list_test␊
>>> ltc2984_test␊
>>> mcp2515_can_bit_timings_test␊
>>> pair_test␊
>>> periodic_timer_test␊
>>> platform_gpio_test␊
FAIL: platform_gpio_test:65 : true == false␊
FAIL: platform_gpio_test:69 : true == false␊
FAIL: platform_gpio_test:70 : true == false␊
>>> protothread_test␊
>>> register_test␊
>>> resumable_test␊
>>> scheduler_test␊
>>> spi_bitbang_test␊
FAIL: spi_bitbang_test:38 : 1 == 17␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
failed at 'h' with '-1987099064'␊
  0 -1987099064      0 (0us)␊
␊
  0 -1987099064      0 (0us)␊
␊
FAIL: spi_bitbang_test:48 : 1 == 9␊
FAIL: spi_bitbang_test:49 : 1 == 17␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
failed at 'h' with '-1986974982'␊
  0 -1986974982      0 (0us)␊
␊
FAIL: spi_bitbang_test:58 : 1 == 3␊
FAIL: spi_bitbang_test:59 : 1 == 17␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
failed at 'h' with '-1986825830'␊
  0 -1986825830      0 (0us)␊
␊
FAIL: spi_bitbang_test:69 : 1 == 3␊
FAIL: spi_bitbang_test:70 : 1 == 17␊
  0 -1986696062      0 (0us)␊
␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
failed at 'h' with '-1986696062'␊
>>> spi_device_test␊
>>> time_test␊
>>> timeout_test␊
>>> timestamp_test␊
>>> tmp12x_test␊
␊
Failed 18 of 2645 tests␊
FAIL!␊

Nucleo-F103_B

Passed 2060 tests␊
OK!␊
Unittests (Dec 31 2021, 19:13:21)␊
Machine:  ...
User:     ...
Os:       Linux-5.15.11-200.fc35.x86_64-x86_64-with-glibc2.34␊
Compiler: arm-none-eabi-g++ 10.2.1␊
Local Git User:␊
...
Last Commit:␊
SHA:             d2ed678349c396c145bd8082ecc33c2e24c8a189␊
Abbreviated SHA: d2ed678349␊
Subject:         fixup: lvgl 8.1.0 compile errors␊
␊
Author:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
Committer:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
File Status:␊
Modified:  0␊
Added:     0␊
Deleted:   0␊
Renamed:   0␊
Copied:    0␊
Untracked: 0␊
␊
>>> LUDecomposition_test␊
>>> angle_test␊
>>> arithmetic_traits_test␊
>>> bit_operation_test␊
>>> circle_2d_test␊
>>> debounce_test␊
>>> endianness_test␊
>>> fir_test␊
>>> lagrange_interpolation_test␊
>>> line_2d_test␊
>>> line_segment_2d_test␊
>>> linear_interpolation_test␊
>>> location_2d_test␊
>>> matrix_test␊
>>> matrix_vector_test␊
>>> median_test␊
>>> moving_average_test␊
>>> operator_test␊
>>> pid_test␊
>>> point_set_2d_test␊
>>> polygon_2d_test␊
>>> prescaler_test␊
>>> quaternion_test␊
>>> ramp_test␊
>>> range_test␊
>>> ray_2d_test␊
>>> s_curve_controller_test␊
>>> s_curve_generator_test␊
>>> saturation_test␊
>>> vector1_test␊
>>> vector2_test␊
>>> vector3_test␊
>>> vector4_test␊
>>> vector_test␊
␊
Passed 2060 tests␊
OK!␊

Nucleo-F411

Failed 11 of 6026 tests␊
FAIL!␊
Unittests (Dec 31 2021, 19:15:52)␊
Machine:  ...
User:     ...
Os:       Linux-5.15.11-200.fc35.x86_64-x86_64-with-glibc2.34␊
Compiler: arm-none-eabi-g++ 10.2.1␊
Local Git User:␊
...
Last Commit:␊
SHA:             d2ed678349c396c145bd8082ecc33c2e24c8a189␊
Abbreviated SHA: d2ed678349␊
Subject:         fixup: lvgl 8.1.0 compile errors␊
␊
Author:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
Committer:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
File Status:␊
Modified:  0␊
Added:     0␊
Deleted:   0␊
Renamed:   0␊
Copied:    0␊
Untracked: 0␊
␊
>>> LUDecomposition_test␊
>>> ad7280a_test␊
>>> angle_test␊
>>> arithmetic_traits_test␊
>>> atomic_queue_test␊
>>> bit_operation_test␊
>>> block_allocator_test␊
>>> bme280_test␊
>>> bmp085_test␊
>>> bounded_deque_test␊
>>> bounded_queue_test␊
>>> bounded_stack_test␊
>>> button_group_test␊
>>> button_test␊
>>> can_bit_timings_test␊
>>> can_connector_base_test␊
>>> can_connector_test␊
>>> can_lawicel_formatter_test␊
>>> can_message_test␊
>>> circle_2d_test␊
>>> clock_test␊
>>> color_test␊
>>> debounce_test␊
>>> delay_test␊
>>> dispatcher_test␊
>>> doubly_linked_list_test␊
>>> drv832x_spi_test␊
>>> dynamic_array_test␊
>>> endianness_test␊
>>> fiber_test␊
>>> fir_test␊
>>> flash_test␊
>>> gpio_sampler_test␊
Channel 0:␊
1674753654␊
1674753787␊
1674849912␊
1674946027␊
1675042140␊
Channel 1:␊
1674753655␊
1675138260␊
1675234381␊
1675330494␊
1675426609␊
FAIL: gpio_sampler_test:71 : -133 not in range [0,96000]␊
FAIL: gpio_sampler_test:72 : -96125 not in range [96000,105600]␊
FAIL: gpio_sampler_test:73 : -96115 not in range [96000,105600]␊
FAIL: gpio_sampler_test:74 : -96113 not in range [96000,105600]␊
FAIL: gpio_sampler_test:77 : -384605 not in range [384000,393600]␊
FAIL: gpio_sampler_test:78 : -96121 not in range [96000,105600]␊
FAIL: gpio_sampler_test:79 : -96113 not in range [96000,105600]␊
FAIL: gpio_sampler_test:80 : -96115 not in range [96000,105600]␊
>>> i2c_test␊
>>> inplace_any_test␊
>>> interface_test␊
>>> interface_test␊
>>> io_stream_test␊
>>> lagrange_interpolation_test␊
>>> line_2d_test␊
>>> line_segment_2d_test␊
>>> linear_interpolation_test␊
>>> linked_list_test␊
>>> location_2d_test␊
>>> ltc2984_test␊
>>> matrix_test␊
>>> matrix_vector_test␊
>>> mcp2515_can_bit_timings_test␊
>>> median_test␊
>>> message_test␊
>>> moving_average_test␊
>>> node_test␊
>>> operator_test␊
>>> pair_test␊
>>> periodic_timer_test␊
>>> pid_test␊
>>> platform_gpio_test␊
FAIL: platform_gpio_test:66 : true == false␊
FAIL: platform_gpio_test:74 : true == false␊
FAIL: platform_gpio_test:79 : true == false␊
>>> point_set_2d_test␊
>>> polygon_2d_test␊
>>> prescaler_test␊
>>> protothread_test␊
>>> quaternion_test␊
>>> ramp_test␊
>>> range_test␊
>>> ray_2d_test␊
>>> register_test␊
>>> resumable_test␊
>>> s_curve_controller_test␊
>>> s_curve_generator_test␊
>>> saturation_test␊
>>> scheduler_test␊
>>> slave_test␊
>>> spi_bitbang_test␊
failed at 'l' with '1710991588'␊
failed at 'l' with '1710991588'␊
failed at 'h' with '1710996557'␊
failed at 'l' with '1711001484' at diff -4927 '-4320'␊
failed at 'l' with '1711001484'␊
failed at 'h' with '1711006353' at diff -4869 '-4320'␊
failed at 'l' with '1711011266' at diff -4913 '-4320'␊
failed at 'l' with '1711011266'␊
failed at 'h' with '1711016199' at diff -4933 '-4320'␊
failed at 'l' with '1711021044' at diff -4845 '-4320'␊
failed at 'l' with '1711021044'␊
failed at 'h' with '1711025979' at diff -4935 '-4320'␊
failed at 'l' with '1711030824' at diff -4845 '-4320'␊
failed at 'l' with '1711030824'␊
failed at 'h' with '1711035759' at diff -4935 '-4320'␊
failed at 'l' with '1711040604' at diff -4845 '-4320'␊
failed at 'l' with '1711040604'␊
failed at 'h' with '1711045525' at diff -4921 '-4320'␊
failed at 'l' with '1711050442' at diff -4917 '-4320'␊
failed at 'l' with '1711050442'␊
failed at 'h' with '1711055307' at diff -4865 '-4320'␊
failed at 'l' with '1711060222' at diff -4915 '-4320'␊
failed at 'l' with '1711060222'␊
failed at 'h' with '1711065087' at diff -4865 '-4320'␊
failed at 'l' with '1711070002' at diff -4915 '-4320'␊
failed at 'l' with '1711070002'␊
  0 1710991588      0 (0us)␊
  1 1710996557  -4969 (-7us)␊
  2 1711001484  -4927 (-6us)␊
  3 1711006353  -4869 (-5us)␊
  4 1711011266  -4913 (-6us)␊
  5 1711016199  -4933 (-6us)␊
  6 1711021044  -4845 (-5us)␊
  7 1711025979  -4935 (-6us)␊
  8 1711030824  -4845 (-5us)␊
  9 1711035759  -4935 (-6us)␊
 10 1711040604  -4845 (-5us)␊
 11 1711045525  -4921 (-6us)␊
 12 1711050442  -4917 (-6us)␊
 13 1711055307  -4865 (-5us)␊
 14 1711060222  -4915 (-6us)␊
 15 1711065087  -4865 (-5us)␊
 16 1711070002  -4915 (-6us)␊
␊
  0 1710991588      0 (0us)␊
␊
failed at 'l' with '1711300502'␊
failed at 'h' with '1711300689'␊
failed at 'l' with '1711310580' at diff -9891 '-9120'␊
failed at 'l' with '1711310580'␊
failed at 'h' with '1711320437' at diff -9857 '-9120'␊
failed at 'l' with '1711330290' at diff -9853 '-9120'␊
failed at 'l' with '1711330290'␊
failed at 'h' with '1711340147' at diff -9857 '-9120'␊
failed at 'l' with '1711350072' at diff -9925 '-9120'␊
failed at 'l' with '1711350072'␊
failed at 'h' with '1711359929' at diff -9857 '-9120'␊
failed at 'l' with '1711369784' at diff -9855 '-9120'␊
failed at 'l' with '1711369784'␊
failed at 'l' with '1711300502'␊
failed at 'h' with '1711305555'␊
failed at 'l' with '1711310484' at diff -4929 '-4320'␊
failed at 'l' with '1711310484'␊
failed at 'h' with '1711315427' at diff -4943 '-4320'␊
failed at 'l' with '1711320342' at diff -4915 '-4320'␊
failed at 'l' with '1711320342'␊
failed at 'h' with '1711325351' at diff -5009 '-4320'␊
failed at 'l' with '1711330196' at diff -4845 '-4320'␊
failed at 'l' with '1711330196'␊
failed at 'h' with '1711335207' at diff -5011 '-4320'␊
failed at 'l' with '1711340052' at diff -4845 '-4320'␊
failed at 'l' with '1711340052'␊
failed at 'h' with '1711345063' at diff -5011 '-4320'␊
failed at 'l' with '1711349978' at diff -4915 '-4320'␊
failed at 'l' with '1711349978'␊
failed at 'h' with '1711354919' at diff -4941 '-4320'␊
failed at 'l' with '1711359834' at diff -4915 '-4320'␊
failed at 'l' with '1711359834'␊
failed at 'h' with '1711364775' at diff -4941 '-4320'␊
failed at 'l' with '1711369690' at diff -4915 '-4320'␊
failed at 'l' with '1711369690'␊
failed at 'h' with '1711374699' at diff -5009 '-4320'␊
failed at 'l' with '1711379544' at diff -4845 '-4320'␊
failed at 'l' with '1711379544'␊
  0 1711300502      0 (0us)␊
  1 1711300689   -187 (-1us)␊
  2 1711310580  -9891 (-13us)␊
  3 1711320437  -9857 (-13us)␊
  4 1711330290  -9853 (-13us)␊
  5 1711340147  -9857 (-13us)␊
  6 1711350072  -9925 (-13us)␊
  7 1711359929  -9857 (-13us)␊
  8 1711369784  -9855 (-13us)␊
␊
failed at 'l' with '1726678256'␊
failed at 'h' with '1726707807' at diff -29551 '-28320'␊
failed at 'l' with '1726747076' at diff -39269 '-28320'␊
failed at 'l' with '1726747076'␊
failed at 'l' with '1726678256'␊
failed at 'h' with '1726683225'␊
failed at 'l' with '1726688142' at diff -4917 '-4320'␊
failed at 'l' with '1726688142'␊
failed at 'h' with '1726693011' at diff -4869 '-4320'␊
failed at 'l' with '1726697926' at diff -4915 '-4320'␊
failed at 'l' with '1726697926'␊
failed at 'h' with '1726702791' at diff -4865 '-4320'␊
failed at 'l' with '1726707706' at diff -4915 '-4320'␊
failed at 'l' with '1726707706'␊
failed at 'h' with '1726712727' at diff -5021 '-4320'␊
failed at 'l' with '1726717572' at diff -4845 '-4320'␊
failed at 'l' with '1726717572'␊
failed at 'h' with '1726722507' at diff -4935 '-4320'␊
failed at 'l' with '1726727352' at diff -4845 '-4320'␊
failed at 'l' with '1726727352'␊
failed at 'h' with '1726732287' at diff -4935 '-4320'␊
failed at 'l' with '1726737202' at diff -4915 '-4320'␊
failed at 'l' with '1726737202'␊
failed at 'h' with '1726742067' at diff -4865 '-4320'␊
failed at 'l' with '1726746982' at diff -4915 '-4320'␊
failed at 'l' with '1726746982'␊
failed at 'h' with '1726751923' at diff -4941 '-4320'␊
failed at 'l' with '1726756838' at diff -4915 '-4320'␊
failed at 'l' with '1726756838'␊
  0 1726678256      0 (0us)␊
  1 1726707807 -29551 (5us)␊
  2 1726747076 -39269 (-6us)␊
␊
  0 1738287544      0 (0us)␊
  1 1738297535  -9991 (-14us)␊
  2 1738336720 -39185 (-5us)␊
␊
failed at 'l' with '1738287544'␊
failed at 'h' with '1738297535' at diff -9991 '-9120'␊
failed at 'l' with '1738336720' at diff -39185 '-9120'␊
failed at 'l' with '1738336720'␊
failed at 'l' with '1738287544'␊
failed at 'h' with '1738292509'␊
failed at 'l' with '1738297432' at diff -4923 '-4320'␊
failed at 'l' with '1738297432'␊
failed at 'h' with '1738302387' at diff -4955 '-4320'␊
failed at 'l' with '1738307302' at diff -4915 '-4320'␊
failed at 'l' with '1738307302'␊
failed at 'h' with '1738312161' at diff -4859 '-4320'␊
failed at 'l' with '1738317078' at diff -4917 '-4320'␊
failed at 'l' with '1738317078'␊
failed at 'h' with '1738322007' at diff -4929 '-4320'␊
failed at 'l' with '1738326852' at diff -4845 '-4320'␊
failed at 'l' with '1738326852'␊
failed at 'h' with '1738331783' at diff -4931 '-4320'␊
failed at 'l' with '1738336628' at diff -4845 '-4320'␊
failed at 'l' with '1738336628'␊
failed at 'h' with '1738341635' at diff -5007 '-4320'␊
failed at 'l' with '1738346550' at diff -4915 '-4320'␊
failed at 'l' with '1738346550'␊
failed at 'h' with '1738351409' at diff -4859 '-4320'␊
failed at 'l' with '1738356326' at diff -4917 '-4320'␊
failed at 'l' with '1738356326'␊
failed at 'h' with '1738361185' at diff -4859 '-4320'␊
failed at 'l' with '1738366102' at diff -4917 '-4320'␊
failed at 'l' with '1738366102'␊
>>> spi_device_test␊
>>> time_test␊
>>> timeout_test␊
>>> timestamp_test␊
>>> tmp12x_test␊
>>> vector1_test␊
>>> vector2_test␊
>>> vector3_test␊
>>> vector4_test␊
>>> vector_test␊
␊
Failed 11 of 6026 tests␊
FAIL!␊
␊

Nucleo-F091

Assertion 'nvic.undef' @ 0xFFFFFFF3 (4294967283) failed!␊
Abandoning...␊
Unittests (Dec 31 2021, 19:22:51)␊
Machine:  ...
User:     ...
Os:       Linux-5.15.11-200.fc35.x86_64-x86_64-with-glibc2.34␊
Compiler: arm-none-eabi-g++ 10.2.1␊
Local Git User:␊
...
Last Commit:␊
SHA:             d2ed678349c396c145bd8082ecc33c2e24c8a189␊
Abbreviated SHA: d2ed678349␊
Subject:         fixup: lvgl 8.1.0 compile errors␊
␊
Author:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
Committer:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
File Status:␊
Modified:  0␊
Added:     0␊
Deleted:   0␊
Renamed:   0␊
Copied:    0␊
Untracked: 0␊
␊
>>> LUDecomposition_test␊
>>> ad7280a_test␊
>>> angle_test␊
>>> arithmetic_traits_test␊
>>> atomic_queue_test␊
>>> bit_operation_test␊
>>> block_allocator_test␊
>>> bme280_test␊
>>> bmp085_test␊
>>> bounded_deque_test␊
>>> bounded_queue_test␊
>>> bounded_stack_test␊
>>> button_group_test␊
>>> button_test␊
>>> can_bit_timings_test␊
>>> can_connector_base_test␊
>>> can_connector_test␊
>>> can_lawicel_formatter_test␊
>>> can_message_test␊
>>> circle_2d_test␊
>>> clock_test␊
>>> color_test␊
>>> debounce_test␊
>>> delay_test␊
>>> dispatcher_test␊
>>> doubly_linked_list_test␊
>>> drv832x_spi_test␊
>>> dynamic_array_test␊
>>> endianness_test␊
>>> fiber_test␊
>>> fir_test␊
>>> flash_test␊
>>> i2c_test␊
>>> inplace_any_test␊
>>> interface_test␊
>>> interface_test␊
>>> io_stream_test␊
>>> lagrange_interpolation_test␊
>>> line_2d_test␊
>>> line_segment_2d_test␊
>>> linear_interpolation_test␊
>>> linked_list_test␊
>>> location_2d_test␊
>>> ltc2984_test␊
>>> matrix_test␊
>>> matrix_vector_test␊
>>> mcp2515_can_bit_timings_test␊
>>> median_test␊
>>> message_test␊
>>> moving_average_test␊
>>> node_test␊
>>> operator_test␊
>>> pair_test␊
>>> periodic_timer_test␊
>>> pid_test␊
>>> point_set_2d_test␊
>>> polygon_2d_test␊
>>> prescaler_test␊
>>> protothread_test␊
>>> quaternion_test␊
>>> ramp_test␊
>>> range_test␊
>>> ray_2d_test␊
>>> register_test␊
>>> resumable_test␊
>>> s_curve_controller_test␊
>>> s_curve_generator_test␊
>>> saturation_test␊
>>> scheduler_test␊
>>> slave_test␊
Assertion 'nvic.undef' @ 0xFFFFFFF3 (4294967283) failed!␊
Abandoning...␊

Nucleo-L432

Passed 4876 tests␊
OK!␊
Unittests (Dec 31 2021, 19:23:43)␊
Machine:  ...
User:     ...
Os:       Linux-5.15.11-200.fc35.x86_64-x86_64-with-glibc2.34␊
Compiler: arm-none-eabi-g++ 10.2.1␊
Local Git User:␊
...
Last Commit:␊
SHA:             d2ed678349c396c145bd8082ecc33c2e24c8a189␊
Abbreviated SHA: d2ed678349␊
Subject:         fixup: lvgl 8.1.0 compile errors␊
␊
Author:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
Committer:␊
Name:      Christopher Durand␊
Email:     christopher.durand@rwth-aachen.de␊
Date:      2021-12-31 18:49:20+01:00␊
Timestamp: 1640972960␊
␊
File Status:␊
Modified:  0␊
Added:     0␊
Deleted:   0␊
Renamed:   0␊
Copied:    0␊
Untracked: 0␊
␊
>>> LUDecomposition_test␊
>>> ad7280a_test␊
>>> angle_test␊
>>> arithmetic_traits_test␊
>>> atomic_queue_test␊
>>> bit_operation_test␊
>>> block_allocator_test␊
>>> bme280_test␊
>>> bmp085_test␊
>>> bounded_deque_test␊
>>> bounded_queue_test␊
>>> bounded_stack_test␊
>>> button_group_test␊
>>> button_test␊
>>> can_bit_timings_test␊
>>> can_connector_base_test␊
>>> can_connector_test␊
>>> can_lawicel_formatter_test␊
>>> can_message_test␊
>>> circle_2d_test␊
>>> clock_test␊
>>> color_test␊
>>> debounce_test␊
>>> delay_test␊
>>> dispatcher_test␊
>>> doubly_linked_list_test␊
>>> drv832x_spi_test␊
>>> dynamic_array_test␊
>>> endianness_test␊
>>> fiber_test␊
>>> fir_test␊
>>> flash_test␊
>>> i2c_test␊
>>> inplace_any_test␊
>>> interface_test␊
>>> interface_test␊
>>> io_stream_test␊
>>> lagrange_interpolation_test␊
>>> line_2d_test␊
>>> line_segment_2d_test␊
>>> linear_interpolation_test␊
>>> linked_list_test␊
>>> location_2d_test␊
>>> ltc2984_test␊
>>> matrix_test␊
>>> matrix_vector_test␊
>>> mcp2515_can_bit_timings_test␊
>>> median_test␊
>>> message_test␊
>>> moving_average_test␊
>>> node_test␊
>>> operator_test␊
>>> pair_test␊
>>> periodic_timer_test␊
>>> pid_test␊
>>> point_set_2d_test␊
>>> polygon_2d_test␊
>>> prescaler_test␊
>>> protothread_test␊
>>> quaternion_test␊
>>> ramp_test␊
>>> range_test␊
>>> ray_2d_test␊
>>> register_test␊
>>> resumable_test␊
>>> s_curve_controller_test␊
>>> s_curve_generator_test␊
>>> saturation_test␊
>>> scheduler_test␊
>>> slave_test␊
>>> spi_device_test␊
>>> time_test␊
>>> timeout_test␊
>>> timestamp_test␊
>>> tmp12x_test␊
>>> vector1_test␊
>>> vector2_test␊
>>> vector3_test␊
>>> vector4_test␊
>>> vector_test␊
␊
Passed 4876 tests␊
OK!␊
␊

@salkinium
Copy link
Member Author

Ugh, the GPIO Sampler and SPI BitBang stuff is broken itself, rather than the tests. It's probably not relevant.
I guess the F091 is running out of memory…

@salkinium
Copy link
Member Author

salkinium commented Dec 31, 2021

Tested TinyUSB in hardware, works fine…

I'm going to merge this tomorrow and then do the release.

@salkinium salkinium merged commit 9bf7d20 into modm-io:develop Jan 1, 2022
@salkinium
Copy link
Member Author

@rleh something is broken for the doxygen API docs https://docs.modm.io/develop/api/stm32f469zit6/

@rleh
Copy link
Member

rleh commented Jan 1, 2022

@rleh something is broken for the doxygen API docs https://docs.modm.io/develop/api/stm32f469zit6/

The index.html files are missing in the generated documentation.

$ find web/2021q3/api/ | grep "index\.html" | wc -l
231
$ find web/develop/api/ | grep "index\.html" | wc -l
0

Can be reproduced with the test (-t2) device list locally with and without deduplication (-d):

$ python3 tools/scripts/docs_modm_io_generator.py -c -j8 -d -t2
[...]
$ tar -tzvf modm-api-docs.tar.gz | grep index
-rw-rw-r-- user/user      7171 2022-01-01 18:25 ./index.html

@chris-durand
Copy link
Member

I am getting segfaults of doxypress on Ubuntu 20.04 with the recent version (1.4.1).

@salkinium
Copy link
Member Author

Ah, crap the CI job also segfaults but doesn't show an error…

@salkinium salkinium deleted the release/2021q4 branch January 1, 2022 17:38
@rleh
Copy link
Member

rleh commented Jan 1, 2022

I am getting segfaults of doxypress on Ubuntu 20.04 with the recent version (1.4.1).

Can't reproduce that on my Fedora 35 system with an Doxypress version 1.3.7 and the current version 1.4.1.

$ doxypress --version

DoxyPress Version: 1.3.7
email: info@copperspice.com

But the Github Actions log contains a lot of the Segmentation fault (core dumped) messages.
That is probably the issue 😒

@salkinium
Copy link
Member Author

salkinium commented Jan 1, 2022

v1.4.0 also segfaults on macOS 10.14:

sh: line 1:  8099 Segmentation fault: 11  doxypress doxypress.json > /dev/null 2>&1

But I don't recall this being broken since March 2021, so it's probably something in our config?

modm-ext/docker-modm-build@cc9412e#diff-6669d8b6099da98872eb7444474b09d8d14cc5663f2cc6612e3b0be4ac5a4215

Edit: Obviously it worked for the Q3 release, so it's not Doxypress itself.

@rleh
Copy link
Member

rleh commented Jan 1, 2022

https://github.com/modm-io/modm/runs/4582015012 (triggered by #748) is the first CI job with segmentation faults.

@chris-durand
Copy link
Member

chris-durand commented Jan 1, 2022

I am getting the same crash with the Q3 release tag checked out. Ubuntu for sure updated some libraries, it could be an ABI problem with the doxygen release binaries.

@rleh
Copy link
Member

rleh commented Jan 1, 2022

We could try to re-run the last successful job (https://github.com/modm-io/modm/actions/runs/1596734183), what do you think?

Update: In progress https://github.com/modm-io/modm/actions/runs/1596734183

@chris-durand
Copy link
Member

chris-durand commented Jan 1, 2022

Sorry, hit the wrong key on the keyboard, Q3 does not work at all for me. Getting an infinite recursion in the docs generator python script (RecursionError: maximum recursion depth exceeded while calling a Python object ).

EDIT: I ran it again and now it works ...

@salkinium
Copy link
Member Author

Checking out that commit (d2ac8d2) and running the Python docs script python3 tools/scripts/docs_modm_io_generator.py -c -j8 -d -t2 works fine for me, but just the next commit (68cb1f9) adding the MCP7941X driver segfaults.

@salkinium
Copy link
Member Author

EDIT: I ran it again and now it works ...

Got the same behaviour, I think its some bytecode caching somewhere… 🙀

@chris-durand
Copy link
Member

8cb1f9

Exactly the same for me. The commit with the MCP7941X driver makes doxypress crash.

@chris-durand
Copy link
Member

Got the same behaviour, I think its some bytecode caching somewhere… 🙀

🙀 🙀 🙀

@salkinium
Copy link
Member Author

At least the issue is just this one driver, so we don't have to do a new release, all other examples seem to generate the documentation just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants