Enable flash driver for STM32G4

[rasmuskleist]

The flash implementation has been tested on STM32g474ret6. It does not implement bank selection for dual bank modes. Also it resolves and issue with g0 devices where the EOP flag should be cleared after programming.

[rleh]

Hi and welcome to modm!

Thanks for your pull request.
I have a few comments, see below.

[rleh]

Could you add an example for on of our STM32G4 dev boards (Nucleo-G431KB, Nucleo-G431RB, Nucleo-G474RE; if you have access to one of them?), so that the CI actually compiles the code? I suggest copying the nucleo_g071rb/flash example.

[rleh]

Tested on my Nucleo-G431KB:

Reboot␊
Erasing sectors [32, 64)␊
Erasing done in 704757us with errors: 0␊
Erasing with 95kiB/s␊
Programming done in 700045us with errors: 0␊
Programming with 95kiB/s␊

Works ✅

Thanks!

[rleh]

I have now triggered the extensive HAL tests.
If they run successfully, the commits just need to be squashed into two commits (e.g. Adapt and enable flash driver for STM32G4 + [example] Add flash examples for STM32G4) and then we can merge.
Do you want to squash the commits or should I do it?

[rasmuskleist]

Feel free to do it!

[salkinium]

Nice!

[rleh]

Feel free to do it!

Sorry @rasmuskleist, but I am not able to push to the branch of this Pull Request, probably because the [ ] Allow edits and access to secrets by maintainers checkbox is not ticked:

(see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork for more information)

Could you tick the checkbox for me to push the squashed commits?
If that doesn't work (there could be an issue with the permissions because your modm repo is in the https://github.com/DanSTAR-DTU namespace and not in a personal namespace) it would be great if you put the squashed commits I pushed here on a branch in my repo on your branch.
Let me know if you need support in using Git for this!

[rasmuskleist]

It does not seem like I can let others work on the pull request unfortunately. Instead I added your repo as a remote and rebased my origin/feature-flash to rleh/feature-flash. I hope this is what your meant otherwise I would like to get some Git support.

[rleh]

Perfekt, thanks!