Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform:timer] support std::chrono in Timer**::setPeriod #873

Merged
merged 2 commits into from
Jun 13, 2022
Merged

[platform:timer] support std::chrono in Timer**::setPeriod #873

merged 2 commits into from
Jun 13, 2022

Conversation

TomSaw
Copy link
Contributor

@TomSaw TomSaw commented Jun 9, 2022 •
edited
Loading

+consistent use of typename uint16_t Value in Timer Types.
+I'm not motivated to maintain the whole Timer code right now :P There's a lot / too much that may be improved,
f.e.

  • more code could be shared between Timer types / instances
  • More handy API-methods taking chrono::duration could be provided

@TomSaw TomSaw changed the title [platform] support std::chrono for platform:Timer**::setPeriod() [platform] support std::chrono for platform::Timer**::setPeriod Jun 9, 2022
@TomSaw TomSaw changed the title [platform] support std::chrono for platform::Timer**::setPeriod [platform] support std::chrono in platform::Timer**::setPeriod Jun 9, 2022
@TomSaw TomSaw force-pushed the feature/timer-setPeriod-use-chrono branch 4 times, most recently from d784d0c to b106366 Compare June 9, 2022 20:14
@TomSaw TomSaw changed the title [platform] support std::chrono in platform::Timer**::setPeriod [platform:timer] support std::chrono in platform::Timer**::setPeriod Jun 11, 2022
@TomSaw TomSaw changed the title [platform:timer] support std::chrono in platform::Timer**::setPeriod [platform:timer] support std::chrono in Timer**::setPeriod Jun 11, 2022
salkinium
salkinium reviewed Jun 12, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/modm/platform/timer/stm32/advanced.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/timer/stm32/advanced.hpp.in Show resolved Hide resolved
@TomSaw TomSaw force-pushed the feature/timer-setPeriod-use-chrono branch from b106366 to 5ddcab3 Compare June 12, 2022 11:26
@TomSaw
Copy link
Contributor Author

TomSaw commented Jun 12, 2022

Delicious!

@salkinium
Copy link
Member

Can you also check if there are examples that need to be updated?

@TomSaw TomSaw force-pushed the feature/timer-setPeriod-use-chrono branch from c626704 to c949daf Compare June 12, 2022 14:36
salkinium
salkinium approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium merged commit c949daf into modm-io:develop Jun 13, 2022
@salkinium salkinium added this to the 2022q2 milestone Jun 13, 2022
@TomSaw TomSaw deleted the feature/timer-setPeriod-use-chrono branch June 13, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
enhancement 🌈
Milestone
2022q2
Development

Successfully merging this pull request may close these issues.
4 participants
@TomSaw @salkinium @rleh @chris-durand