Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads7828 driver #887

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Ads7828 driver #887

merged 1 commit into from
Jul 20, 2022

Conversation

JKazem
Copy link
Contributor

@JKazem JKazem commented Jul 17, 2022

Ads7828 driver implementation with example for the NucleoG474. The example uses the same pins as on our custom board on which the driver has been tested.

@JKazem JKazem force-pushed the feature/ads7828 branch 4 times, most recently from 027633e to 7b30eaa Compare July 17, 2022 17:38
@salkinium salkinium added this to the 2022q3 milestone Jul 17, 2022
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

examples/nucleo_g474re/ads7828/main.cpp Show resolved Hide resolved
src/modm/driver/adc/ads7828.lb Show resolved Hide resolved
@chris-durand chris-durand self-requested a review July 17, 2022 20:48
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/modm/driver/adc/ads7828.hpp Outdated Show resolved Hide resolved
src/modm/driver/adc/ads7828.hpp Show resolved Hide resolved
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Squash?

@JKazem JKazem force-pushed the feature/ads7828 branch 2 times, most recently from ef777c5 to f0ebbcc Compare July 20, 2022 11:24
…ample uses the same pins as on our custom board on which the driver has been tested.
@JKazem
Copy link
Contributor Author

JKazem commented Jul 20, 2022

Okay no more changes. Hope it wasnt too much of an incovenience

@salkinium salkinium merged commit 0cd2bc9 into modm-io:develop Jul 20, 2022
@twast92 twast92 deleted the feature/ads7828 branch July 20, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants