Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCP9902/3/4 temperature sensor driver #894

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Aug 9, 2022

Simplistic driver for MCP9902/3/4 temperature sensor. Tested in hardware on a custom board with an STM32F302C8. The example is not tested yet.

@chris-durand
Copy link
Member Author

The example is also working.

@chris-durand chris-durand requested a review from rleh August 9, 2022 12:58
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful driver.
I have a few comments or suggestions for improvement:

src/modm/driver/temperature/mcp990x_impl.hpp Show resolved Hide resolved
src/modm/driver/temperature/mcp990x.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/mcp990x.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/mcp990x.hpp Show resolved Hide resolved
src/modm/driver/temperature/mcp990x.lb Outdated Show resolved Hide resolved
@chris-durand
Copy link
Member Author

I have also added functionality for using the external diode sensors for completeness, but I can't test it with the boards I have.

Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/modm/driver/temperature/mcp990x.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/mcp990x.lb Outdated Show resolved Hide resolved
@salkinium salkinium merged commit 0fd53a8 into modm-io:develop Aug 11, 2022
@chris-durand chris-durand deleted the feature/mcp990x branch August 11, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants