Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SAM software gpio port #952

Merged
merged 5 commits into from
Feb 4, 2023
Merged

Add SAM software gpio port #952

merged 5 commits into from
Feb 4, 2023

Conversation

chris-durand
Copy link
Member

SAM GPIO improvements:

  • Add SoftwareGpioPort implementation
  • Allow construction of GpioSet from Gpios, not only config classes
  • Add support for inverted pins in GpioSet
  • Working hardware unit test for SoftwareGpioPort

salkinium
salkinium approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@salkinium salkinium added this to the 2023q1 milestone Feb 2, 2023
@salkinium
Copy link
Member

Actually, do you want to update the relevant SAM BSPs with this implementation? I think there are still some hacks in there.

@chris-durand
Copy link
Member Author

Actually, do you want to update the relevant SAM BSPs with this implementation?

Done

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Feb 4, 2023
@salkinium salkinium force-pushed the feature/sam_software_gpio_port branch from 7def600 to afdb5ba Compare February 4, 2023 14:47
@salkinium salkinium merged commit afdb5ba into modm-io:develop Feb 4, 2023
@chris-durand chris-durand deleted the feature/sam_software_gpio_port branch February 4, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-durand @salkinium