[xpcc] Separate the rx handling part of the update fct of the dispatcher #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleh
reviewed
Mar 12, 2023
se-bi
force-pushed
the
feature/separate-xpcc-update-rx-handling
branch
from
e5ce603
to
17d5aa7
Compare
rleh
reviewed
Mar 12, 2023
se-bi
force-pushed
the
feature/separate-xpcc-update-rx-handling
branch
from
17d5aa7
to
711cb80
Compare
rleh
reviewed
Mar 12, 2023
|
Could you rebase (after #843 is merged), I forgot to merge this before the previous PR 🤦 |
rleh
approved these changes
Mar 13, 2023
Call that separated function instead and have it available as a public function as well.
se-bi
force-pushed
the
feature/separate-xpcc-update-rx-handling
branch
from
711cb80
to
2273bae
Compare
Sure, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call that separated function instead
and have it available as a public function as well.
Then it is possible to use the XPCC dispatcher and postman,
and combine e.g. the zeromq gateway example with that.