Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sam] Add SAMx7x DMA + DAC #987

Merged
merged 7 commits into from
Apr 10, 2023
Merged

[sam] Add SAMx7x DMA + DAC #987

merged 7 commits into from
Apr 10, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Mar 28, 2023 •
edited
Loading

  • DAC driver
  • DMA Driver
    • Block transfer mode
    • Linked list transfer mode
  • Update modm-devices
  • Examples
    • Block transfer with DAC
    • Linked list transfer with DAC
    • Simple DAC example without DMA
  • Test examples in hardware
  • Documentation for DMA driver

@chris-durand chris-durand force-pushed the feature/samx7x_dma branch 2 times, most recently from 755f6a9 to d87be72 Compare March 28, 2023 02:06
@chris-durand chris-durand changed the title [sam] Add SAMx7x DMA [sam] Add SAMx7x DMA + DAC Apr 6, 2023
@chris-durand chris-durand marked this pull request as ready for review April 6, 2023 17:51
@chris-durand chris-durand force-pushed the feature/samx7x_dma branch 3 times, most recently from b6fc8b8 to 2195a72 Compare April 6, 2023 22:46
@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 6, 2023
@chris-durand chris-durand added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Apr 7, 2023
salkinium
salkinium approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That LinkedListTransfer implementation is pretty dope!

examples/samv71_xplained_ultra/dac/main.cpp Outdated Show resolved Hide resolved
examples/samv71_xplained_ultra/dac/main.cpp Outdated Show resolved Hide resolved
examples/samv71_xplained_ultra/dma/block_transfer/main.cpp Outdated Show resolved Hide resolved
examples/samv71_xplained_ultra/dma/linked_list_transfer/main.cpp Outdated Show resolved Hide resolved
src/modm/platform/dac/sam_x7x/dac.hpp Outdated Show resolved Hide resolved
src/modm/platform/dma/samx7x/channel_impl.hpp Show resolved Hide resolved
src/modm/platform/dma/samx7x/module.lb Show resolved Hide resolved
@salkinium salkinium added this to the 2023q2 milestone Apr 8, 2023
rleh
rleh approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just a few minor comments 🙂

src/modm/platform/dac/sam_x7x/dac_impl.hpp.in Show resolved Hide resolved
ext/st/stm32 Outdated Show resolved Hide resolved
src/modm/platform/dma/samx7x/base_impl.hpp Show resolved Hide resolved
src/modm/platform/dma/samx7x/dma.cpp Outdated Show resolved Hide resolved
src/modm/platform/dac/sam_x7x/dac.hpp Show resolved Hide resolved
examples/samv71_xplained_ultra/dma/block_transfer/main.cpp Outdated Show resolved Hide resolved
@chris-durand chris-durand added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Apr 10, 2023
salkinium
salkinium approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge, @rleh?

@chris-durand
Copy link
Member Author

Please wait with merging. I'll run a final hardware test in about 3 hours when I have access to an oscilloscope. Just to be sure I broke nothing in a refactoring. I could merge after the test.

@chris-durand
Copy link
Member Author

It's still working, I'll merge.
RigolDS2

@chris-durand chris-durand merged commit 182948d into modm-io:develop Apr 10, 2023
@chris-durand chris-durand deleted the feature/samx7x_dma branch April 10, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-durand @salkinium @rleh