Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm_thread_creation Buttons instead of reactions #3273

Merged
merged 11 commits into from
Jul 15, 2023

Conversation

martinbndr
Copy link
Contributor

This pr replaces reactions with buttons for the confirm_thread_creation feature.
Buttons should be more userfriendly and stable for this feature. Changes tested, should work 100%

Taaku18
Taaku18 previously approved these changes Jul 12, 2023
Copy link
Collaborator

@Taaku18 Taaku18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR. I updated some relevant messages regarding the change, and removed the changelog entry–as it'll be added later once merged.

@Taaku18 Taaku18 added staged Staged for next version and removed pending review labels Jul 12, 2023
@Taaku18 Taaku18 merged commit 77fbb69 into modmail-dev:development Jul 15, 2023
2 checks passed
@Taaku18 Taaku18 mentioned this pull request Jul 15, 2023
raidensakura pushed a commit to raidensakura/modmail that referenced this pull request Apr 10, 2024
* Reminder Plugin

Created a reminder plugin

* Fix indentations

* confirm_thread_creation Buttons instead of reactions

* Changelog+Small fixes

* Updated the react to confirm message, and removed changelog entry

* Code linting with black

* Update changelog

---------

Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged Staged for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants