Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created confirm_thread_creation_timeout config #3304

Merged
merged 6 commits into from
Oct 27, 2024

Conversation

sebkuip
Copy link
Member

@sebkuip sebkuip commented Sep 8, 2023

This PR adds a config variable allowing users to set their own timeout for the confirm_thread_creation.

This required the addition of an ints category of configs for conversion as well.

To make the lower and upper limits work, I have added a new system allowing the setting of limits. This will be compared by a python statement like lower <= value <= upper only for keys specified. It will be tested when the value is set, and reverts to the previous value if invalid.

I have added a description in the json file, along with adding this config to the notes of all other related configs.

@sebkuip sebkuip changed the base branch from master to development September 8, 2023 10:12
@Taaku18
Copy link
Collaborator

Taaku18 commented Nov 19, 2023

Seems like there's a merge conflict. I don't have permission to make the necessary changes, but it looks like this could be fixed by changing ConfirmThreadCreationView in utils.py to take a timeout parameter, and then changing view to view = ConfirmThreadCreationView(timeout=self.bot.config[confirm_thread_creation_timeout]) in thread.py.

raidensakura and others added 5 commits May 15, 2024 11:48
* Update Dockerfile

* Use the slim-bookworm image, refactored some steps

* Disable user login

* Capitalize comment

---------

Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
@Taaku18 Taaku18 merged commit 041c4fd into modmail-dev:development Oct 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants