Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathBuf#set_extension messes up version names #24

Closed
Bendimester23 opened this issue Mar 24, 2022 · 1 comment · Fixed by #17
Closed

PathBuf#set_extension messes up version names #24

Bendimester23 opened this issue Mar 24, 2022 · 1 comment · Fixed by #17

Comments

@Bendimester23
Copy link

Minecraft version names contain dots, but Rust's PathBuf interprets it as an extension which is being changed in theseus/src/launcher/download.rs on line 26 to json. This messes up version names in files as shown in this image:
image
However when starting the game, the version jar file is added to the classpath as 1.18.2-0.13.3.jar, causing an error on Fabric and a crash on vanilla.
image

One not too elegant but working solution would be to just use PathBuf#push to append the .json and the .jar extension to the filename.
@enderger
Copy link
Contributor

This is actually fixed by #17

@triphora triphora linked a pull request Mar 24, 2022 that will close this issue
Initial draft of profile metadata format & CLI #17
Merged
Geometrically pushed a commit that referenced this issue Jul 4, 2024
@CodexAdrian
Toggles (#24)
f97c948 
* Toggles!

* Toggle component

* Ran prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial draft of profile metadata format & CLI enderger/theseus
2 participants
@enderger @Bendimester23