Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement loading #104

Merged
merged 27 commits into from
May 10, 2023
Merged

Implement loading #104

merged 27 commits into from
May 10, 2023

Conversation

CodexAdrian
Copy link
Contributor

Fixes MOD-337

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason for packs like cobblemon there's a huge delay before the loading indicator. Does this happen for you too? Might be a backend bug.

Some design notes:

  • In places like the loading button on the instance, I think a white version of the Modrinth logo would look better instead of the green version.
  • For the general design of the launcher "widget", here's what I think it should be modeled similarly to the Browser's download tray (firefox is a rlly good example).

Design:

  • There should be a similar animation when showing/hiding to the avatar dropdown on the site
  • I think it would look a lot better to ditch the modrinth logo and pecentage and replace it with a loading bar, and have the text which specifies what is loading be smaller.
  • When a new loading starts, it would be nice to autofocus/show the loading menu and the user has to click away to hide it. Or there could be an animation of the downloading icon "jiggling" to indicate a downloading action has started.
  • There should be margin between the loading card and the navbar and the edge of the screen. Right now it kinda looks jammed in there

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will wait for wyatt's loading bar changes

@Geometrically Geometrically merged commit 71cf2c5 into master May 10, 2023
@Geometrically Geometrically deleted the loading branch May 10, 2023 22:50
Geometrically pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants