-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wires up profile settings & allows profiles to be repaired or deleted. #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs:
- When clicking "Browse" and then clicking cancel, it says the java value to null. This is a problem on the settings page as well
- Settings don't save at all for me (you should use the profile edit hook)
Visual:
-
There should be a confirm modal for deleting an instance and repairing an instance (with the repair describing what it does)
-
The java settings input and buttons should be inlined like they are on the settings
-
For each setting, if the setting is null it should take the value of the global settings. Instead of being directly modifiable, the user should select if they would like to override the global setting. If they do, the inputs should be undisabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superseded by #120 |
Fixes MOD-382
Fixes MOD-367
Fixes MOD-394
Notes:
await install
, so this may be like a deadlock.