Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wires up profile settings & allows profiles to be repaired or deleted. #105

Closed
wants to merge 10 commits into from

Conversation

ZachBaird
Copy link
Contributor

@ZachBaird ZachBaird commented May 4, 2023

Fixes MOD-382
Fixes MOD-367
Fixes MOD-394

  • Hammer icon added.
  • Repair button with Highlight color and Hammer added in Options.vue
  • Delete button added in Options.vue
  • Profile settings wired up in Options.vue

Notes:

  • The delete action sends the user back to pages/Index.vue. I wasn't sure if it should go anywhere else or if we should perhaps load projects/Instance for the former profile.
  • Repair action seems to run forever. Execution never returns after await install, so this may be like a deadlock.
  • There doesn't seem to be a method for updating a profile (in order to update the settings).
  • There is some layover UI from when Adrian initially mocked this up. I kept it for now incase we want to wire it up.

@ZachBaird ZachBaird changed the title Adds instance deletion and repairs to Options.vue Wires up profile settings & allows profiles to be repaired or deleted. May 5, 2023
Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs:

  • When clicking "Browse" and then clicking cancel, it says the java value to null. This is a problem on the settings page as well
  • Settings don't save at all for me (you should use the profile edit hook)

Visual:

  • There should be a confirm modal for deleting an instance and repairing an instance (with the repair describing what it does)

  • The java settings input and buttons should be inlined like they are on the settings

  • For each setting, if the setting is null it should take the value of the global settings. Instead of being directly modifiable, the user should select if they would like to override the global setting. If they do, the inputs should be undisabled.

image
Something similar to this could work.

This is how Prism/MultiMC does it:
image

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This should also show the first mod loader

@Geometrically
Copy link
Member

superseded by #120

@Geometrically Geometrically deleted the repair-delete-instance branch May 19, 2023 03:41
Geometrically pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants