Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading bars #113

Merged
merged 5 commits into from
May 10, 2023
Merged

Loading bars #113

merged 5 commits into from
May 10, 2023

Conversation

Geometrically
Copy link
Member

@Geometrically Geometrically commented May 10, 2023 •
edited
Loading

Fixes MOD-388

ZachBaird
ZachBaird reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@ZachBaird ZachBaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works locally! Smart use of global state.

Doesn't seem we actually use the nuxt-loading-indicator class in Theseus or Omorphia, so that bit could probably be quickly removed.

@Geometrically Geometrically merged commit 9be0d16 into master May 10, 2023
@Geometrically Geometrically deleted the loading-bars branch May 10, 2023 18:29
Geometrically pushed a commit that referenced this pull request Jul 4, 2024
@brawaru
Fix ambiguous default export (#113)
5051ad9 
Currently Omorphia's index file has both the default and named exports.
While this is totally supported by native ESM, it's pretty hard for
transpilers to process and may lead to situations where named exports
cannot be imported directly, requiring destructuring on the default
import. For this and just consistency reasons, you'd usually avoid
mixing default and named exports.

This commit removes the default export, making it just an another named
export called `plugin`.

BREAKING CHANGE: plugin is now exported using `plugin` export, rather
than the default export.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachBaird ZachBaird ZachBaird approved these changes

@CodexAdrian CodexAdrian Awaiting requested review from CodexAdrian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geometrically @ZachBaird