Various final backend fixes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesuzerain
suggested changes
May 16, 2023
theseus/src/state/mod.rs
Outdated
| use tokio::sync::{OnceCell, RwLock, Semaphore}; | ||
|
|
||
| use futures::{ |
There was a problem hiding this comment.
clippy error warning here and in a few other places (only marked here because I think a --fix will fix it globally). (I also have 'fmt'-resolvable warnings when I open the branch in vscode)
theseus/src/state/profiles.rs
Outdated
| "Fetched {path:?}" | ||
| ); | ||
| } else { | ||
| println!( |
There was a problem hiding this comment.
Probably not needed to do println! inside the API. The current CLI setup and playground should both have a tracing subscriber and should be able to see the tracing logs in API functions.
There was a problem hiding this comment.
yup, was just for debugging
|
LGTM |
thesuzerain
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-406
Fixes MOD-407
Fixes MOD-389
Fixes MOD-310