Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jre detection #54

Merged
merged 12 commits into from
Mar 28, 2023
Merged

Jre detection #54

merged 12 commits into from
Mar 28, 2023

Conversation

thesuzerain
Copy link
Contributor

@thesuzerain thesuzerain commented Mar 27, 2023 •
edited by Geometrically
Loading

Added JRE detection using function get_all_jre(), which returns a vec of unique JavaVersions with all symlinks resolved.

FIxes MOD-309

Geometrically
Geometrically requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides 2 minor things

theseus/src/util/jre.rs Outdated Show resolved Hide resolved
theseus/src/util/jre.rs Outdated Show resolved Hide resolved
@Geometrically Geometrically merged commit 8512b45 into master Mar 28, 2023
@Geometrically Geometrically deleted the jre-detection branch March 28, 2023 17:31
Geometrically added a commit that referenced this pull request Jul 4, 2024
@Geometrically
Remove uses of iconified-button (#54)
4243bf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometrically Geometrically Geometrically approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesuzerain @Geometrically