Tauri errors fix #61
Merged
Tauri errors fix #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thesuzerain
commented
Apr 3, 2023
thesuzerain
commented
- changes most uses of ZipArchive to use async_zip crate instead
- crate::Result now has Send and Sync again, which fixes Tauri problem
Geometrically
requested changes
Apr 3, 2023
theseus/src/state/projects.rs
Outdated
| &icon_path, cache_dir, bytes, &permit, | ||
| ) | ||
| .await?; | ||
| let zip_file_reader = ZipFileReader::new(path).await?; |
There was a problem hiding this comment.
this shouldn't be "question-marked". if the zip is invalid the func shouldn't fail
Geometrically
approved these changes
Apr 3, 2023
Geometrically
added a commit
that referenced
this pull request
Apr 6, 2023
* Modpack support * Finish feature * Tauri errors fix (#61) * async impl * working * fmt and redundancy * moved ? to if let Ok block * Finish modpacks support * remove generated file * fix compile err * fix lint * Fix code review comments + forge support --------- Co-authored-by: Wyatt Verchere <wverchere@gmail.com>
Geometrically
added a commit
that referenced
this pull request
Jul 4, 2024
* Fix publish act * Fix again:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.