Child process manager api #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Apr 5, 2023
theseus/src/state/children.rs
Outdated
| if let Some(child_stdout) = child.stdout.take() { | ||
| let stdout_clone = stdout.clone(); | ||
| tokio::spawn(async move { | ||
| stdout_clone.read_stdout(child_stdout).await.unwrap(); |
There was a problem hiding this comment.
no unwraps! properly handle errors here. by the way, does this sync up? like will this constantly stream input? the code seems to be just one time
Geometrically
requested changes
Apr 5, 2023
| }, | ||
| State, | ||
| }; | ||
|
|
There was a problem hiding this comment.
One thing that is missing is getting all running profiles. The main use case I see for this is displaying the running profile(s) in the app bar
Geometrically
approved these changes
Apr 5, 2023
Geometrically
pushed a commit
that referenced
this pull request
Jul 4, 2024
* fix some styling (oops) * Update pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-335