Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project pages #65

Merged
merged 17 commits into from
Apr 7, 2023
Merged

Project pages #65

merged 17 commits into from
Apr 7, 2023

Conversation

CodexAdrian
Copy link
Contributor

@CodexAdrian CodexAdrian commented Apr 4, 2023 •
edited by Geometrically
Loading

Fixes MOD-283
Fixes MOD-284
Fixes MOD-286
Fixes MOD-287
Fixes MOD-288

Geometrically
Geometrically requested changes Apr 4, 2023
View reviewed changes
theseus_gui/src/pages/project/Changelog.vue Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Version.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Show resolved Hide resolved
Geometrically
Geometrically requested changes Apr 4, 2023
View reviewed changes
theseus_gui/src/helpers/utils.js Outdated Show resolved Hide resolved
Geometrically
Geometrically requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to run lint via prettier and eslint (it will fix the failing check)

Geometrically
Geometrically requested changes Apr 6, 2023
View reviewed changes
Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you're using ofetch instead of the browser fetch

theseus_gui/src/assets/stylesheets/global.scss Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Gallery.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Gallery.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Gallery.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Gallery.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Version.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Version.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Outdated Show resolved Hide resolved
Geometrically
Geometrically requested changes Apr 6, 2023
View reviewed changes
theseus_gui/dist/.gitignore Outdated Show resolved Hide resolved
theseus_gui/dist/assets/index-8da58892.css Outdated Show resolved Hide resolved
theseus_gui/dist/assets/index-9fe84dd5.js Outdated Show resolved Hide resolved
theseus_gui/dist/index.html Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Gallery.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Index.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Version.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Version.vue Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/project/Versions.vue Show resolved Hide resolved
@Geometrically Geometrically merged commit 34f4b76 into master Apr 7, 2023
@Geometrically Geometrically deleted the project-pages branch April 7, 2023 01:06
Geometrically pushed a commit that referenced this pull request Jul 4, 2024
@CodexAdrian
Slider and text input changes (#65)
cea5a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometrically Geometrically Geometrically approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodexAdrian @Geometrically