Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow and mrpack fixes, comfortable memory slider and more. #762

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Overflow and mrpack fixes, comfortable memory slider and more. #762

merged 7 commits into from
Oct 2, 2023

Conversation

qtchaos
Copy link
Contributor

@qtchaos qtchaos commented Sep 21, 2023 •
edited
Loading

  1. Added a limit for the instance name in the breadcrumbs, so that a very long (~50char) instance name doesn't push aside the other elements, making exiting the application impossible. Fixed overflow in mod browse. Fixes Long instance names are not handled correctly #740
  2. Added a limit of 100 characters in the instance creation modal, there is no reason for an instance's name to be longer.
  3. Fixed log viewing options overflowing with a small window, now they are scrollable.
  4. Increased instance avatar size from sm to lg in the library so that the gray corners in icons are less visible.
  5. Fixed and rounded the white corner in the log viewer.
  6. Increase step to 64 for memory related inputs for a more consistent and comfortable experience.
  7. Fix instances imported from an mrpack file throwing an error (making it impossible to unpair a locally imported mrpack) when viewing. Fixes Imported mrpack instance says "error fetching project" #747
  8. Removed changing modpack versions on instances imported from a local mrpack.

image
image
image
image

@qtchaos qtchaos changed the title Fix overflow in certain scenarios. Various QOL improvements Sep 21, 2023
@qtchaos
Copy link
Contributor Author

qtchaos commented Sep 24, 2023

Ready for review ^0^

@qtchaos qtchaos changed the title Various QOL improvements Overflow and mrpack fixes, comfortable memory slider and more. Oct 1, 2023
@Geometrically Geometrically merged commit 6f8ffca into modrinth:master Oct 2, 2023
2 of 6 checks passed
@qtchaos qtchaos deleted the overflow-fixes branch October 2, 2023 17:58
Geometrically added a commit that referenced this pull request Jul 4, 2024
@Geometrically
Add project redir + fix version 404 (#762)
e08d803
Geometrically added a commit that referenced this pull request Oct 16, 2024
@thesuzerain @Geometrically
Side types overhaul (#762)
f731c10 
* side types overhaul

* fixes, fmt clippy

* migration fix for v3 bug

* fixed migration issues

* more tested migration changes

* fmt, clippy

* bump cicd

---------

Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometrically Geometrically Geometrically approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imported mrpack instance says "error fetching project" Long instance names are not handled correctly
2 participants
@qtchaos @Geometrically