Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display App version in settings #801

Merged
merged 2 commits into from
Nov 21, 2023
Merged

display App version in settings #801

merged 2 commits into from
Nov 21, 2023

Conversation

ToBinio
Copy link
Contributor

@ToBinio ToBinio commented Oct 10, 2023

This PR adds a small area to the settings where the current version of the launcher is shown
grafik

This should resolve #737

pauliesnug
pauliesnug suggested changes Oct 22, 2023
View reviewed changes
theseus_gui/src/pages/Settings.vue Outdated Show resolved Hide resolved
triphora
triphora previously requested changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@triphora triphora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a setting, so it doesn't make sense to put it in a section called "settings". Maybe at the very end of the options, a little debug section that also has stuff like OS, etc.

@ToBinio
Copy link
Contributor Author

ToBinio commented Oct 28, 2023

moved it to the bottom of the settings page:

grafik

called the section about (as suggested in #737 )

adding more things to the section should in my opinion be done in another PR even though the section is pretty empty now (this is why I didn't do it originally )

note:
sry for the mess of a commit history tried to fix it but everything just got worse...

@ToBinio ToBinio requested a review from triphora October 28, 2023 14:39
@triphora triphora removed their request for review October 28, 2023 14:57
@Geometrically
Copy link
Member

pls fix conflicts

@ToBinio
Copy link
Contributor Author

ToBinio commented Nov 16, 2023

should be fixed.

note:
i believe i did something wrong while rebasing it as I needed to run lints again.

pauliesnug
pauliesnug suggested changes Nov 17, 2023
View reviewed changes
Copy link

@pauliesnug pauliesnug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

theseus_gui/src/helpers/metadata.js Outdated Show resolved Hide resolved
theseus_gui/src/helpers/profile.js Outdated Show resolved Hide resolved
theseus_gui/src/pages/Settings.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/Settings.vue Outdated Show resolved Hide resolved
pauliesnug
pauliesnug approved these changes Nov 18, 2023
View reviewed changes
Copy link

@pauliesnug pauliesnug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 :3

@Geometrically Geometrically merged commit 531b38e into modrinth:master Nov 21, 2023
2 of 3 checks passed
@ToBinio ToBinio deleted the launcher-version branch November 21, 2023 17:01
Geometrically added a commit that referenced this pull request Oct 16, 2024
@thesuzerain @Geometrically
country testing (#801)
9f79855 
Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauliesnug pauliesnug pauliesnug approved these changes

@Geometrically Geometrically Geometrically approved these changes

@triphora triphora triphora left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launcher version number
4 participants
@ToBinio @Geometrically @triphora @pauliesnug