String settings hooks #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Apr 13, 2023
theseus/src/api/profile.rs
Outdated
Comment on lines
238
to
255
| let post_exit_hooks = | ||
| &profile.hooks.as_ref().unwrap_or(&settings.hooks).post_exit; | ||
|
|
||
| let post_exit_hooks: Vec<Command> = post_exit_hooks | ||
| .iter() | ||
| .filter_map(|hook| { | ||
| let mut cmd = hook.split(' '); | ||
| if let Some(command) = cmd.next() { | ||
| let mut command = Command::new(command); | ||
| command | ||
| .args(&cmd.map(|s| s.to_string()).collect::<Vec<String>>()) | ||
| .current_dir(path); | ||
| Some(command) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
weren't we only doing one command for the post exit hooks?
There was a problem hiding this comment.
Yeah- it is only one command .but in this part its stored as a vec because previously it went from an iter to a vec (and you can iter over an Option so it worked mostly in place without changing this aspect)
I agree this is misleading though- so fixed.
| @@ -74,6 +76,14 @@ impl Settings { | |||
| } | |||
| } | |||
|
|
|||
| /// Theseus theme | |||
| #[derive(Debug, Clone, Copy, Serialize, Deserialize)] | |||
| pub enum Theme { | |||
There was a problem hiding this comment.
would use a rename all snake case here
ZachBaird
approved these changes
Apr 15, 2023
…string-settings-hooks
…string-settings-hooks
Geometrically
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-380 + other miscellaneous things