-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up homepage & library #83
Conversation
…plays play or X ctas.
It appears that killing a process by the uuid doesn't work on Tauri's side. I have verified that the process-uuid I need to kill is in the running list, and had the proper uuid for the method. Below are screenshots of the behavior I was seeing: It looks like the method is just erroring in the backend and the uuid just gets added to the list of running processes forever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes:
- Instance should use Avatar component
- The home page should integrate with the Profile Events API to subscribe when profiles are added/deleted so it can update on it's page
- It should also integrate with the process API to sync up when instances are being played/stopped and update the UI accordingly
- Installed modpacks should be hidden (can use facets to filter them out)
Visual changes (just noticed these overall but probs should make changes here):
- The brightness fllter on hover doesn't have a transition and the play/stop button is affected by the filter when it shouldn't
- The Instance element and play/stop buttons should act like a button (can use
button-base
orclickable
) as in they should shrink when clicked and animate
I know you mentioned throwing the router.push in a lambda on the card. This PR sees the Instance component being able to go to some different pages based on the prop coming in: Handling this in the template started to feel ugly, so I held off for now so you could see. Up to you if we keep it here or put it in the template anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- App bar was not merged correctly (still shows mod install count)
- When installing a pack, even when it is installed, the search page isn't refreshed and the instance list is still outdated
- Linked Project ID API has changed, library page modpack tab doesn't work either
Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hovering over the instance card, then hovering over the play button changes the background of the instance cards
- There is a bunch of extra padding on instance cards now, making them be larger than they should be
- There is no transition on the instance card background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glitched w the new navbar- also the navbar pagination indicators don't seem to be there anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see dm
…into wire-up-homepage
* Fix resize text * fix multiselect
Fixes MOD-366
Fixes MOD-384
followers
. Any modpacks or mods in the recent list are excluded from the search.Notes: