Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up homepage & library #83

Merged
merged 49 commits into from
May 9, 2023
Merged

Wire up homepage & library #83

merged 49 commits into from
May 9, 2023

Conversation

ZachBaird
Copy link
Contributor

@ZachBaird ZachBaird commented Apr 15, 2023

Fixes MOD-366
Fixes MOD-384

  • A RowDisplay will not render if there are no instances in it.
  • Home page's 2nd and 3rd rows are now populated by popular modpacks/mods from the search API. These are popular in the sense of followers. Any modpacks or mods in the recent list are excluded from the search.
  • Install, Play, and Stop buttons are wired up. ConfirmationModal brought in.
  • If a process is started, play button is replaced with an X button.
  • If a process is running, and the user leaves but returns to the page, the X button will still show.
  • Instance.vue modified to handle either instance data from Tauri or from Search.
  • RouterLink removed. Stopping event propagation on the play/install btns was unreliable. Router.push is called if the card is clicked on.
  • Stop Btn is now capable of killing all running UUIDs related to a profile.
  • App bar now displays some realtime data when a modpack is being installed
  • Some CSS in App.vue was fixed because content was going off screen. It messed with the header chevrons for paging.

Notes:

  • Library PR closed and branch merged here.

theseus_gui/src/components/RowDisplay.vue Outdated Show resolved Hide resolved
theseus_gui/src/components/ui/Instance.vue Outdated Show resolved Hide resolved
theseus_gui/src/components/ui/Instance.vue Show resolved Hide resolved
theseus_gui/src/components/ui/Instance.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/Index.vue Outdated Show resolved Hide resolved
theseus_gui/src/pages/Index.vue Outdated Show resolved Hide resolved
@ZachBaird
Copy link
Contributor Author

It appears that killing a process by the uuid doesn't work on Tauri's side. I have verified that the process-uuid I need to kill is in the running list, and had the proper uuid for the method. Below are screenshots of the behavior I was seeing:

image

It looks like the method is just erroring in the backend and the uuid just gets added to the list of running processes forever.

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes:

  • Instance should use Avatar component
  • The home page should integrate with the Profile Events API to subscribe when profiles are added/deleted so it can update on it's page
  • It should also integrate with the process API to sync up when instances are being played/stopped and update the UI accordingly
  • Installed modpacks should be hidden (can use facets to filter them out)

Visual changes (just noticed these overall but probs should make changes here):

  • The brightness fllter on hover doesn't have a transition and the play/stop button is affected by the filter when it shouldn't
  • The Instance element and play/stop buttons should act like a button (can use button-base or clickable) as in they should shrink when clicked and animate

theseus_gui/src/components/ui/Instance.vue Outdated Show resolved Hide resolved
theseus_gui/src/components/ui/Instance.vue Show resolved Hide resolved
theseus_gui/src/pages/Index.vue Outdated Show resolved Hide resolved
@ZachBaird
Copy link
Contributor Author

I know you mentioned throwing the router.push in a lambda on the card. This PR sees the Instance component being able to go to some different pages based on the prop coming in:

image

Handling this in the template started to feel ugly, so I held off for now so you could see. Up to you if we keep it here or put it in the template anyway.

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • App bar was not merged correctly (still shows mod install count)
  • When installing a pack, even when it is installed, the search page isn't refreshed and the instance list is still outdated
  • Linked Project ID API has changed, library page modpack tab doesn't work either

@ZachBaird
Copy link
Contributor Author

ZachBaird commented Apr 29, 2023

The events seem to have had a regression in the data they contain when sent down to the front end. Looks like stuff like fractions are just null for most of the process:

image

There isn't really anything to look for here in the front end that makes sense and is reasonable to check if we're ready to update our instances list. I went with a particular unique message for now, but the way the events were before worked great.

Resolved

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Hovering over the instance card, then hovering over the play button changes the background of the instance cards
  • There is a bunch of extra padding on instance cards now, making them be larger than they should be
  • There is no transition on the instance card background

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glitched w the new navbar- also the navbar pagination indicators don't seem to be there anymore

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see dm

@Geometrically Geometrically merged commit ba20c48 into master May 9, 2023
@Geometrically Geometrically deleted the wire-up-homepage branch May 9, 2023 23:48
Geometrically added a commit that referenced this pull request Jul 4, 2024
* Fix resize text

* fix multiselect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants