fix rendering/calculation of maxProjectsPerRow in homepage #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a weird behavior that sometimes causes too many projects to be displayed
reason why this happened:
the
onMounthock renders the page and then gets called which in most cases results in the container element in which the projects are rendered to be the correct width without any projects being inside them.There is just the edge case where the height of the projects adds a scrollbar on the side which changes the width of the container without triggering a resize.
this PR fixes this by always rendering one element which forces a scrollbar to be rendered before
onMount