-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non modpack wireup & Project to profile install #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Installing anything to a existing profile doesn't seem to work (see console)
- I think the installed selection everywhere would look better if they had a checkmark next to it
- The text for the selected instance says "1.19.4 fabric", IMO "Fabric 1.19.4" would be a lot better (also should we add an indicator saying it's the selected instance?
unrelated but would be nice to fix in this pr:
- make the project sidebar like the other sidebar, where it doesn't scroll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bugs:
- going to a project's pages versions when you are adding a mod then clicking install incorrectly brings up the modal
design:
- for consistency IMO the add mods should let you click on the title/avatar to go to the profile and close the modal
- there should be an easy way to get back to search/your previous view when adding a mod and going to the page from search. maybe breadcrumbs at the top of the selector like this?
- Add Mods should be renamed to "Add Projects" or something similar
- search project type selector should be changed to a navrow
- the search headings aren't being respected
Also should add an option to create a vanilla instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some bugs:
- Clicking a filter when you are paginated doesn't reset the pagination (IK it's not caused by this PR but since you're working with search would be nice to fix)
- Project Type is not remembered when going back to browse
- Even when an instance is "deselected" after doing the whole add mods flow, the game versions, and other search items are not reset
- Resource Packs should be able to be installed if they are from a version before/equal to an instances (like a 1.8.9 pack should be able to be installed a 1.19 instance)
- Shader installation also doesn't seem to work
- Shader/DataPacks/ResourcePacks should ignore loaders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I click on a mod in a profile it shows as not installed and lets me install it.
Looks good otherwise!
Fixes MOD-376
Fixes MOD-365