Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for uploading to multiple modrinth projects at once #23

Open
pupnewfster opened this issue May 27, 2022 · 4 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@pupnewfster
Copy link

It would be nice if there was a better system for publishing to multiple Modrinth projects from a single gradle project. Mekanism is setup in multiple modules split by sourcesets, that then get built into individual jars. A more native way in Minotaur to handle cases like this would be useful and allow for easier automated publishing. The solution/workaround (mekanism/Mekanism@188d050) I came up with while performing some experimentation works by creating new TaskModrinthUploads and then using doFirst to change the configured values of the ModrinthExtension before the task is applied and it queries the extension for values.

Some potential solutions from an API perspective that I come up with might be:

  • Similar to how the dependencies block is a nested configuration, making it so some of the properties of the ModrinthExtension are nested and then it loops them uploading all to the corresponding projects
  • A configuration version of the values set in ModrinthExtension that can be passed to the TaskModrinthUpload when created/applied and just leave it to devs to declare when they are declaring the custom upload tasks.
@pupnewfster pupnewfster added the enhancement New feature or request label May 27, 2022
@pupnewfster
Copy link
Author

Adding onto this (I can open it as another request if you would like), one thing that would be useful is to also then have a way to get the version id of uploaded files. That way for all my secondary projects I could mark them as requiring the matching version of the main project instead of just being able to mark them as requiring the main project in general.

@triphora
Copy link
Contributor

Obtaining the version ID of the uploaded file can be obtained via tasks.modrinth.uploadInfo.id if I recall correctly.

@pupnewfster
Copy link
Author

Ah yeah, seems I missed that part when suggesting the secondary thing.

@triphora
Copy link
Contributor

Wrong issue to close! Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants